Skip to content

[release-4.18] OCPBUGS-48710, SDN-4930: Disable adding/removing the UDN namespace label #2626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 2 commits into from
Jan 24, 2025
Merged

[release-4.18] OCPBUGS-48710, SDN-4930: Disable adding/removing the UDN namespace label #2626

openshift-merge-bot merged 2 commits into from
Jan 24, 2025

Conversation

@kyrtapz
Copy link
Contributor

@kyrtapz kyrtapz commented Jan 23, 2025

cc: @trozet

trozet and others added 2 commits January 23, 2025 18:41
@trozet @kyrtapz
Disable adding/removing the UDN namespace label
4619935 
UDN namespace label will be required when namespaces are created in
order to use a primary UDN in that namespace.

Co-authored-by: Patryk Diak <pdiak@redhat.com>
Signed-off-by: Tim Rozet <trozet@redhat.com>
(cherry picked from commit 4668f71)
@kyrtapz
Fix user-defined-networks-namespace-label binding
ff1666a 
Signed-off-by: Patryk Diak <pdiak@redhat.com>
(cherry picked from commit 91b8a78)
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 23, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 23, 2025 •
edited by openshift-ci bot
Loading

@kyrtapz: This pull request references SDN-4930 which is a valid jira issue.

Details

In response to this:

cc: @trozet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from abhat and jcaamano January 23, 2025 17:46
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2025

@kyrtapz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node ff1666a link false /test e2e-aws-ovn-single-node
ci/prow/e2e-openstack-ovn ff1666a link false /test e2e-openstack-ovn
ci/prow/e2e-aws-hypershift-ovn-kubevirt ff1666a link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/security ff1666a link false /test security
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 ff1666a link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-azure-ovn ff1666a link false /test e2e-azure-ovn
ci/prow/e2e-network-mtu-migration-ovn-ipv6 ff1666a link false /test e2e-network-mtu-migration-ovn-ipv6
ci/prow/e2e-vsphere-ovn ff1666a link false /test e2e-vsphere-ovn
ci/prow/okd-scos-e2e-aws-ovn ff1666a link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kyrtapz kyrtapz changed the title [release-4.18] SDN-4930: Disable adding/removing the UDN namespace label [release-4.18] OCPBUGS-48710, SDN-4930: Disable adding/removing the UDN namespace label Jan 24, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 24, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 24, 2025 •
edited by openshift-ci bot
Loading

@kyrtapz: This pull request references Jira Issue OCPBUGS-48710, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-48709 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-48709 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references SDN-4930 which is a valid jira issue.

Details

In response to this:

cc: @trozet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

trozet
trozet approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 24, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyrtapz, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@anuragthehatter
Copy link

anuragthehatter commented Jan 24, 2025

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 24, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 3dcc293 into openshift:release-4.18 Jan 24, 2025
23 of 32 checks passed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 24, 2025

@kyrtapz: Jira Issue OCPBUGS-48710: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-48710 has not been moved to the MODIFIED state.

Details

In response to this:

cc: @trozet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 25, 2025

[ART PR BUILD NOTIFIER]

Distgit: cluster-network-operator
This PR has been included in build cluster-network-operator-container-v4.18.0-202501250002.p0.g3dcc293.assembly.stream.el9.
All builds following this will include this PR.

This was referenced Jan 27, 2025
Merged
Merged
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 3, 2025
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Jun 25, 2025
Merged
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Jun 26, 2025

Fix included in accepted release 4.18.0-0.nightly-2025-06-26-034047

@openshift-ci-robot openshift-ci-robot mentioned this pull request Aug 14, 2025
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Oct 22, 2025
Merged
5 tasks
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 23, 2025

Fix included in accepted release 4.18.0-0.nightly-2025-10-23-005402

@openshift-ci-robot openshift-ci-robot mentioned this pull request Dec 22, 2025
Merged
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Dec 25, 2025

Fix included in accepted release 4.18.0-0.nightly-2025-12-24-222251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhat abhat Awaiting requested review from abhat

@jcaamano jcaamano Awaiting requested review from jcaamano

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

1 more reviewer

@trozet trozet trozet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@eurijon eurijon

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@rlobillo rlobillo

@asood-rh asood-rh

@jechen0648 jechen0648

@qiowang721 qiowang721

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.