OCPBUGS-15538,OCPBUGS-19961: Downstream merge 2023-10-10 by pperiyasamy · Pull Request #1935 · openshift/ovn-kubernetes

pperiyasamy · 2023-10-10T15:44:36Z

This would synchronize node primary address update on the address manager which helps to avoid unnecessary update of the same ovn encapsulation ip address into ovs. Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>

Not sure if this case can ever happen, but if we ever get to this code and have no gateways, we want to delete the pod IP from the policy. Just make this safer by checking if 0 or 1 gws are present in the cache, rather than just 1. Signed-off-by: Tim Rozet <trozet@redhat.com>

Hybrid route policies were not unconditionally removed if there was not a matching ECMP route in OVN. This changes the behavior to fully clean hybrid policies as well as any stale addresses that exist in its related address set. Signed-off-by: Tim Rozet <trozet@redhat.com> Co-authored-by: Nadia Pinaeva <npinaeva@redhat.com>

Signed-off-by: Tim Rozet <trozet@redhat.com>

…g net-attach-def This change is to prevent Type Assertion panic in case the object has already been removed but was put into tombstone of type cache.DeletedFinalStateUnknown which contains the deleted key and object JIRA: https://issues.redhat.com/browse/OCPBUGS-19961 Signed-off-by: Arnab Ghosh <arnabghosh89@gmail.com>

Fix exgw hybrid policy

Synchronize node primary address update

openshift-ci-robot · 2023-10-10T15:44:43Z

@pperiyasamy: This pull request references Jira Issue OCPBUGS-15538, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.15.0) matches configured target version for branch (4.15.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

@npinaeva @trozet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Handle tombstone of type cache.DeletedFinalStateUnknown while deleting net-attach-def

pperiyasamy · 2023-10-11T10:36:47Z

/assign @npinaeva @trozet @tssurya

tssurya · 2023-10-11T10:39:50Z

/retitle OCPBUGS-15538,OCPBUGS-19961: Downstream merge 2023-10-10

openshift-ci-robot · 2023-10-11T10:40:28Z

@pperiyasamy: This pull request references Jira Issue OCPBUGS-15538, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.15.0) matches configured target version for branch (4.15.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-19961, which is invalid:

expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

@npinaeva @trozet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tssurya · 2023-10-11T10:41:01Z

/jira refresh

openshift-ci-robot · 2023-10-11T10:41:06Z

@tssurya: This pull request references Jira Issue OCPBUGS-15538, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.15.0) matches configured target version for branch (4.15.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

This pull request references Jira Issue OCPBUGS-19961, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.15.0) matches configured target version for branch (4.15.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tssurya · 2023-10-11T18:58:42Z

/retest

pperiyasamy · 2023-10-12T07:26:17Z

/retest-required

tssurya · 2023-10-12T11:07:14Z

I see disruptions again https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_ovn-kubernetes/1935/pull-ci-openshift-ovn-kubernetes-master-4.15-upgrade-from-stable-4.14-local-gateway-e2e-aws-ovn-upgrade/1712369089361481728 and

{  fail [github.com/openshift/origin/test/extended/prometheus/prometheus.go:577]: Unexpected error:
    <errors.aggregate | len:1, cap:1>: 
    promQL query returned unexpected results:
    ALERTS{alertname!~"Watchdog|AlertmanagerReceiversNotConfigured|PrometheusRemoteWriteDesiredShards|KubeJobFailed|Watchdog|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|KubePodNotReady|etcdMembersDown|etcdMembersDown|etcdGRPCRequestsSlow|etcdGRPCRequestsSlow|etcdHighNumberOfFailedGRPCRequests|etcdHighNumberOfFailedGRPCRequests|etcdMemberCommunicationSlow|etcdMemberCommunicationSlow|etcdNoLeader|etcdNoLeader|etcdHighFsyncDurations|etcdHighFsyncDurations|etcdHighCommitDurations|etcdHighCommitDurations|etcdInsufficientMembers|etcdInsufficientMembers|etcdHighNumberOfLeaderChanges|etcdHighNumberOfLeaderChanges|KubeAPIErrorBudgetBurn|KubeAPIErrorBudgetBurn|KubeClientErrors|KubeClientErrors|KubePersistentVolumeErrors|KubePersistentVolumeErrors|MCDDrainError|MCDDrainError|KubeMemoryOvercommit|KubeMemoryOvercommit|MCDPivotError|MCDPivotError|PrometheusOperatorWatchErrors|PrometheusOperatorWatchErrors|OVNKubernetesResourceRetryFailure|OVNKubernetesResourceRetryFailure|RedhatOperatorsCatalogError|RedhatOperatorsCatalogError|VSphereOpenshiftNodeHealthFail|VSphereOpenshiftNodeHealthFail|SamplesImagestreamImportFailing|SamplesImagestreamImportFailing|PodSecurityViolation",alertstate="firing",severity!="info"} >= 1
    [
      {
        "metric": {
          "__name__": "ALERTS",
          "alertname": "TargetDown",
          "alertstate": "firing",
          "job": "cco-metrics",
          "namespace": "openshift-cloud-credential-operator",
          "prometheus": "openshift-monitoring/k8s",
          "service": "cco-metrics",
          "severity": "warning"
        },
        "value": [
          1697105377.751,
          "1"
        ]
      }

on both upgrades which seem unrelated.
the disruptions might need a close look @pperiyasamy

tssurya · 2023-10-12T11:07:20Z

/retest

pperiyasamy · 2023-10-13T10:35:35Z

@tssurya it seems this disruption is not related to this change, it happened with PR #1702 as well and succeeded in the last run. so would try for another /retest.

tssurya · 2023-10-13T15:43:10Z

/retest

pperiyasamy · 2023-10-16T08:56:11Z

/retest-required

trozet · 2023-10-16T21:20:38Z

/lgtm

openshift-ci · 2023-10-16T21:22:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pperiyasamy, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [trozet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2023-10-17T00:02:29Z

/retest-required

Remaining retests: 0 against base HEAD 1cf6c03 and 2 for PR HEAD bb6a2b2 in total

tssurya · 2023-10-17T10:40:07Z

/retest-required

pperiyasamy · 2023-10-17T13:27:29Z

/retest-required

trozet · 2023-10-17T19:18:46Z

/retest-required

flavio-fernandes · 2023-10-17T20:18:17Z

/test e2e-aws-ovn-kubevirt
/cc @flavio-fernandes

openshift-ci-robot · 2023-10-17T22:08:33Z

@pperiyasamy: Jira Issue OCPBUGS-15538: All pull requests linked via external trackers have merged:

openshift/ovn-kubernetes#1935

Jira Issue OCPBUGS-15538 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-19961: All pull requests linked via external trackers have merged:

openshift/ovn-kubernetes#1935

Jira Issue OCPBUGS-19961 has been moved to the MODIFIED state.

Details

In response to this:

@npinaeva @trozet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot · 2023-10-25T05:29:47Z

Fix included in accepted release 4.15.0-0.nightly-2023-10-24-230302

pperiyasamy and others added 8 commits October 6, 2023 10:44

Synchronize node primary address update

fd9dac3

This would synchronize node primary address update on the address manager which helps to avoid unnecessary update of the same ovn encapsulation ip address into ovs. Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>

Move exgw e2e test out of e2e.go into external_gateways.go

c670398

Signed-off-by: Tim Rozet <trozet@redhat.com>

Merge pull request #3722 from trozet/fix_exgw_hybrid_policy

7ac8956

Fix exgw hybrid policy

Merge pull request #3754 from pperiyasamy/update-primary-address

517cce3

Synchronize node primary address update

Merge remote-tracking branch 'upstream1/master' into merge-11-10-2023

5557853

pperiyasamy requested a review from dcbw as a code owner October 10, 2023 15:44

openshift-ci bot requested review from JacobTanenbaum, anuragthehatter and tssurya October 10, 2023 15:44

trozet and others added 2 commits October 10, 2023 17:23

Merge pull request #3953 from arghosh93/net-attach-def-delete-panic

5183734

Handle tombstone of type cache.DeletedFinalStateUnknown while deleting net-attach-def

Merge remote-tracking branch 'upstream1/master' into merge-11-10-2023

bb6a2b2

openshift-ci bot assigned npinaeva, trozet and tssurya Oct 11, 2023

openshift-ci bot changed the title ~~OCPBUGS-15538: Downstream merge 2023-10-10~~ OCPBUGS-15538,OCPBUGS-19961: Downstream merge 2023-10-10 Oct 11, 2023

openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 11, 2023

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 11, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2023

openshift-ci bot requested a review from flavio-fernandes October 17, 2023 20:18

openshift-ci bot merged commit 30f8cef into openshift:master Oct 17, 2023

Conversation

pperiyasamy commented Oct 10, 2023

Uh oh!

openshift-ci-robot commented Oct 10, 2023

Uh oh!

pperiyasamy commented Oct 11, 2023

Uh oh!

tssurya commented Oct 11, 2023

Uh oh!

openshift-ci-robot commented Oct 11, 2023

Uh oh!

tssurya commented Oct 11, 2023

Uh oh!

openshift-ci-robot commented Oct 11, 2023

Uh oh!

tssurya commented Oct 11, 2023

Uh oh!

pperiyasamy commented Oct 12, 2023

Uh oh!

tssurya commented Oct 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tssurya commented Oct 12, 2023

Uh oh!

pperiyasamy commented Oct 13, 2023

Uh oh!

tssurya commented Oct 13, 2023

Uh oh!

pperiyasamy commented Oct 16, 2023

Uh oh!

trozet commented Oct 16, 2023

Uh oh!

openshift-ci bot commented Oct 16, 2023

Uh oh!

openshift-ci-robot commented Oct 17, 2023

Uh oh!

tssurya commented Oct 17, 2023

Uh oh!

pperiyasamy commented Oct 17, 2023

Uh oh!

trozet commented Oct 17, 2023

Uh oh!

flavio-fernandes commented Oct 17, 2023

Uh oh!

openshift-ci-robot commented Oct 17, 2023

Uh oh!

openshift-merge-robot commented Oct 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

tssurya commented Oct 12, 2023 •

edited

Loading