[DownstreamMerge] 07 jul 23#1747
Conversation
The reason we had our private fork was merged upstream: ovn-kubernetes/ovn-kubernetes#3445 Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
Signed-off-by: haojue <acewhj@gmail.com>
ExternalIDs[defaultDenyPolicyTypeACLExtIdKey] is also used by multicast acls (despite the name), but multicast acl have different priorities. It was not a bug, because multicast acls are updated before default deny, therefore only default deny acls will match the criteria. This commit just makes the filtering more specific. Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
These logs are already moved to cluster-manager Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
If the egress fw was modified while trying to update status, it will just repeatedly fail: ovn-worker2/ovn-kubernetes/ovnkube-network-controller-manager.log:E0621 04:03:47.983023 11526 default_network_controller.go:761] Failed to update egress firewall status egressip-3696/default, error: error in updating status on EgressFirewall egressip-3696/default: Operation cannot be fulfilled on egressfirewalls.k8s.ovn.org "default": the object has been modified; please apply your changes to the latest version and try again Fetch the latest version and update the status. Signed-off-by: Tim Rozet <trozet@redhat.com>
Fix updating egress firewall status
Signed-off-by: Peng Liu <pliu@redhat.com>
… and the namespace no longer exists When a namespace with pods gets removed and the pod removal event is handled after the namespace is already gone, we should ignore the NotFound error in reconcileEgressIPPod. Any potential configuration will get removed in reconcileEgressIPNamespace. Signed-off-by: Patryk Diak <pdiak@redhat.com>
Do not reconcile egressIPPod objects that are being deleted when the namespace no longer exists
Fix acl sync to properly filter default deny acls.
NIT: EIP: Healthchecks have moved to ovnkube-controller
fixes some typos in docs/INSTALL.OPENSHIFT.md
Vendor upstream netlink
openshift-ci
bot
requested review from
jcaamano,
npinaeva,
pliurh,
trozet and
tssurya
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcbw, kyrtapz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/override ci/prow/4.14-upgrade-from-stable-4.13-local-gateway-e2e-aws-ovn-upgrade |
|
@dcbw: Overrode contexts on behalf of dcbw: ci/prow/4.14-upgrade-from-stable-4.13-local-gateway-e2e-aws-ovn-upgrade DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-metal-ipi-ovn-ipv6 /override ci/prow/e2e-metal-ipi-ovn-dualstack |
|
@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-metal-ipi-ovn-dualstack, ci/prow/e2e-metal-ipi-ovn-ipv6 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@kyrtapz: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
10 participants
No conflicts.
/cc @jcaamano @npinaeva @tssurya @pliurh @trozet @dcbw