Skip to content

multinetpolicy: use RetryOnConflict to reduce flakes#28035

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
dcbw:multinet-retry
Jul 9, 2023
Merged

multinetpolicy: use RetryOnConflict to reduce flakes#28035
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
dcbw:multinet-retry

Conversation

@dcbw
Copy link
Contributor

@dcbw dcbw commented Jul 7, 2023

The CNO can rewrite networks.operator.openshift.io while the test is trying to update it. Just retry.

: [sig-network][Feature:MultiNetworkPolicy][Serial] should enforce a network policies on secondary network IPv6 [Suite:openshift/conformance/serial] expand_less 	52s {  fail [github.com/openshift/origin/test/extended/networking/multinetpolicy.go:165]: Unexpected error:
    <*errors.StatusError | 0xc0004f3860>:
    Operation cannot be fulfilled on networks.operator.openshift.io "cluster": the object has been modified; please apply your changes to the latest version and try again
    {
        ErrStatus:
            code: 409
            details:
              group: operator.openshift.io
              kind: networks
              name: cluster
            message: 'Operation cannot be fulfilled on networks.operator.openshift.io "cluster":
              the object has been modified; please apply your changes to the latest version and
              try again'
            metadata: {}
            reason: Conflict
            status: Failure,
    }
occurred
Ginkgo exit error 1: exit with code 1}

@zeeke

@openshift-ci openshift-ci bot requested review from knobunc and trozet July 7, 2023 15:25
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2023
@dcbw dcbw force-pushed the multinet-retry branch from c647c88 to e297b0c Compare July 7, 2023 15:26
The CNO can rewrite networks.operator.openshift.io while the
test is trying to update it. Just retry.

: [sig-network][Feature:MultiNetworkPolicy][Serial] should enforce a network policies on secondary network IPv6 [Suite:openshift/conformance/serial] expand_less 	52s
{  fail [github.com/openshift/origin/test/extended/networking/multinetpolicy.go:165]: Unexpected error:
    <*errors.StatusError | 0xc0004f3860>:
    Operation cannot be fulfilled on networks.operator.openshift.io "cluster": the object has been modified; please apply your changes to the latest version and try again
    {
        ErrStatus:
            code: 409
            details:
              group: operator.openshift.io
              kind: networks
              name: cluster
            message: 'Operation cannot be fulfilled on networks.operator.openshift.io "cluster":
              the object has been modified; please apply your changes to the latest version and
              try again'
            metadata: {}
            reason: Conflict
            status: Failure,
    }
occurred
Ginkgo exit error 1: exit with code 1}
@dcbw dcbw force-pushed the multinet-retry branch from e297b0c to f39355c Compare July 7, 2023 15:27
@zeeke
Copy link
Contributor

zeeke commented Jul 7, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e0aea0e and 2 for PR HEAD f39355c in total

@dcbw
Copy link
Contributor Author

dcbw commented Jul 7, 2023

/override ci/prow/e2e-gcp-ovn
: [sig-api-machinery][Feature:ClusterResourceQuota] Cluster resource quota should control resource limits across namespaces [apigroup:quota.openshift.io][apigroup:image.openshift.io][apigroup:monitoring.coreos.com][apigroup:template.openshift.io] [Suite:openshift/conformance/parallel] is unrelated to this e2e test change for multi network policy

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2023

@dcbw: dcbw unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight.

Details

In response to this:

/override ci/prow/e2e-gcp-ovn
: [sig-api-machinery][Feature:ClusterResourceQuota] Cluster resource quota should control resource limits across namespaces [apigroup:quota.openshift.io][apigroup:image.openshift.io][apigroup:monitoring.coreos.com][apigroup:template.openshift.io] [Suite:openshift/conformance/parallel] is unrelated to this e2e test change for multi network policy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor Author

dcbw commented Jul 7, 2023

/retest-required

1 similar comment
@dcbw
Copy link
Contributor Author

dcbw commented Jul 8, 2023

/retest-required

@dcbw
Copy link
Contributor Author

dcbw commented Jul 8, 2023

/retest-required
To pick up openshift/ovn-kubernetes#1747 that should fix the
Jul 08 05:18:19.613 - 868s W alert/OVNKubernetesResourceRetryFailure node/10.0.0.3:9102 ns/openshift-ovn-kubernetes pod/ovnkube-master-xpd7h container/kube-rbac-proxy ALERTS{alertname="OVNKubernetesResourceRetryFailure", alertstate="firing", container="kube-rbac-proxy", endpoint="metrics", instance="10.0.0.3:9102", job="ovnkube-master", namespace="openshift-ovn-kubernetes", pod="ovnkube-master-xpd7h", prometheus="openshift-monitoring/k8s", service="ovn-kubernetes-master", severity="warning"}}

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a9ffc1e and 1 for PR HEAD f39355c in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 9, 2023

@dcbw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-sdn f39355c link false /test e2e-metal-ipi-sdn
ci/prow/e2e-aws-ovn-single-node-upgrade f39355c link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node f39355c link false /test e2e-aws-ovn-single-node
ci/prow/e2e-gcp-csi f39355c link false /test e2e-gcp-csi
ci/prow/e2e-openstack-ovn f39355c link false /test e2e-openstack-ovn
ci/prow/e2e-agnostic-ovn-cmd f39355c link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-ovn-single-node-serial f39355c link false /test e2e-aws-ovn-single-node-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e9a1f86 and 0 for PR HEAD f39355c in total

@openshift-merge-robot openshift-merge-robot merged commit b716d77 into openshift:master Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants