Skip to content

OCPBUGS-13953: [release-4.12] Use loadbalancer.Name as client index#1680

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.12from
npinaeva:ocpbugs-13953
Jun 2, 2023
Merged

OCPBUGS-13953: [release-4.12] Use loadbalancer.Name as client index#1680
openshift-merge-robot merged 1 commit intoopenshift:release-4.12from
npinaeva:ocpbugs-13953

Conversation

@npinaeva
Copy link
Contributor

@npinaeva npinaeva commented May 23, 2023

Backport of #1660
Simple conflicts on ovn/controller/services/loadbalancer.go

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 23, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 23, 2023

@npinaeva: This pull request references Jira Issue OCPBUGS-13953, which is invalid:

  • expected dependent Jira Issue OCPBUGS-12725 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Backport of #1660
Simple conflicts on ovn/controller/services/loadbalancer.go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dcbw and trozet May 23, 2023 12:53
@npinaeva
Use loadbalancer.Name as client index
8d53f29 
Revert predicate search optimization
3369d38 as predicate search should not
bee needed anymore

Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
(cherry picked from commit ad052c1)

Conflicts:
	go-controller/pkg/libovsdb/libovsdb.go: acl client index is not
merged downstream yet
	go-controller/pkg/ovn/controller/services/loadbalancer.go:
loadbalancer cache removal is not merged downstream yet

(cherry picked from commit ba263ab)
(cherry picked from commit d7e64a9)

Conflicts:
  Use string instead of nbdn constant for LoadBalancerTable

Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
@npinaeva
Copy link
Contributor Author

npinaeva commented May 24, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 24, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 24, 2023

@npinaeva: This pull request references Jira Issue OCPBUGS-13953, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-12725 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-12725 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from anuragthehatter May 24, 2023 08:39
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2023

@npinaeva: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn 8d53f29 link false /test e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

trozet
trozet approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 2, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: npinaeva, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2023
@anuragthehatter
Copy link

anuragthehatter commented Jun 2, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 2, 2023
@openshift-merge-robot openshift-merge-robot merged commit fec58c4 into openshift:release-4.12 Jun 2, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 2, 2023

@npinaeva: Jira Issue OCPBUGS-13953: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13953 has been moved to the MODIFIED state.

Details

In response to this:

Backport of #1660
Simple conflicts on ovn/controller/services/loadbalancer.go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Jun 4, 2023

Fix included in accepted release 4.12.0-0.nightly-2023-06-04-044832

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcbw dcbw Awaiting requested review from dcbw

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

1 more reviewer

@trozet trozet trozet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@zhaozhanqi zhaozhanqi

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@yingwang-0320 yingwang-0320

@qiowang721 qiowang721

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.