Skip to content

OCPBUGS-12725: [release-4.13] Use loadbalancer.Name as client index#1660

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.13from
npinaeva:ocpbugs-12725
May 17, 2023
Merged

OCPBUGS-12725: [release-4.13] Use loadbalancer.Name as client index#1660
openshift-merge-robot merged 1 commit intoopenshift:release-4.13from
npinaeva:ocpbugs-12725

Conversation

@npinaeva
Copy link
Contributor

@npinaeva npinaeva commented Apr 25, 2023 •
edited
Loading

Backport of #1652
no conflicts

@npinaeva
Use loadbalancer.Name as client index
d7e64a9 
Revert predicate search optimization
3369d38 as predicate search should not
bee needed anymore

Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
(cherry picked from commit ad052c1)

Conflicts:
	go-controller/pkg/libovsdb/libovsdb.go: acl client index is not
merged downstream yet
	go-controller/pkg/ovn/controller/services/loadbalancer.go:
loadbalancer cache removal is not merged downstream yet

(cherry picked from commit ba263ab)
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 25, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 25, 2023

@npinaeva: This pull request references Jira Issue OCPBUGS-12725, which is invalid:

  • expected dependent Jira Issue OCPBUGS-11716 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Backport of #1652

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 25, 2023

@npinaeva: This pull request references Jira Issue OCPBUGS-12725, which is invalid:

  • expected dependent Jira Issue OCPBUGS-11716 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Backport of #1652
no conflicts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2023

@npinaeva: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-12725: [release-4.13] Use loadbalancer.Name as client index

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2023

@npinaeva: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-12725: [release-4.13] Use loadbalancer.Name as client index

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dcbw and tssurya April 25, 2023 15:12
@trozet
Copy link
Contributor

trozet commented Apr 26, 2023

/approved
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 26, 2023
@trozet
Copy link
Contributor

trozet commented Apr 26, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: npinaeva, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2023
@npinaeva
Copy link
Contributor Author

npinaeva commented May 3, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 3, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 3, 2023

@npinaeva: This pull request references Jira Issue OCPBUGS-12725, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-11716 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-11716 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from anuragthehatter May 3, 2023 16:08
@anuragthehatter
Copy link

anuragthehatter commented May 3, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 3, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 3, 2023

/retest-required

Remaining retests: 0 against base HEAD 49f6f05 and 2 for PR HEAD d7e64a9 in total

@npinaeva
Copy link
Contributor Author

npinaeva commented May 5, 2023

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2023 •
edited
Loading

@npinaeva: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-hypershift d7e64a9 link false /test e2e-aws-ovn-hypershift
ci/prow/e2e-ovn-hybrid-step-registry d7e64a9 link false /test e2e-ovn-hybrid-step-registry
ci/prow/e2e-openstack-ovn d7e64a9 link false /test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@npinaeva
Copy link
Contributor Author

npinaeva commented May 5, 2023

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 86284e6 into openshift:release-4.13 May 17, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 17, 2023

@npinaeva: Jira Issue OCPBUGS-12725: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-12725 has been moved to the MODIFIED state.

Details

In response to this:

Backport of #1652
no conflicts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented May 18, 2023

Fix included in accepted release 4.13.0-0.nightly-2023-05-17-174018

@npinaeva npinaeva deleted the ocpbugs-12725 branch May 22, 2023 10:19
@npinaeva npinaeva mentioned this pull request May 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcbw dcbw Awaiting requested review from dcbw

@tssurya tssurya Awaiting requested review from tssurya

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@zhaozhanqi zhaozhanqi

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@yingwang-0320 yingwang-0320

@qiowang721 qiowang721

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.