Skip to content

Conversation

@jbtrystram
Copy link
Contributor

This reverts commit f0a5e7a. The unpinning was not intentional and it will be reverted in [1][2]. Let's revert here as well to match.

[1] openshift/ovn-kubernetes#2663
[2] openshift/ovn-kubernetes@7427c98

This reverts commit f0a5e7a.
The unpinning was not intentional and it will be reverted in [1][2].
Let's revert here as well to match.

[1] openshift/ovn-kubernetes#2663
[2] openshift/ovn-kubernetes@7427c98
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 18, 2025
@openshift-ci-robot
Copy link

@jbtrystram: This pull request references Jira Issue OCPBUGS-59303, which is invalid:

  • expected the bug to target the "4.18.z" version, but no target version was set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-55453 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead
  • expected dependent Jira Issue OCPBUGS-55453 to target a version in 4.19.0, 4.19.z, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This reverts commit f0a5e7a. The unpinning was not intentional and it will be reverted in [1][2]. Let's revert here as well to match.

[1] openshift/ovn-kubernetes#2663
[2] openshift/ovn-kubernetes@7427c98

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from c4rt0 and jmarrero July 18, 2025 03:15
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2025
@jbtrystram
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2025
@zshi-redhat
Copy link
Contributor

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2025

@jbtrystram: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@c4rt0 c4rt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: c4rt0, jbtrystram

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson
Copy link
Member

sdodson commented Jul 22, 2025

openshift/ovn-kubernetes#2678 is repinning in ovk-kubernetes so we'll move forward with this

@sdodson
Copy link
Member

sdodson commented Jul 22, 2025

/hold cancel
/label jira/valid-bug backport-risk-assessed cherry-pick-approved

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2025
@sdodson sdodson added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 22, 2025
@sdodson sdodson merged commit 96f1c70 into openshift:release-4.18 Jul 22, 2025
4 of 5 checks passed
@openshift-ci-robot
Copy link

@jbtrystram: Jira Issue OCPBUGS-59303: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-59303 has been moved to the MODIFIED state.

Details

In response to this:

This reverts commit f0a5e7a. The unpinning was not intentional and it will be reverted in [1][2]. Let's revert here as well to match.

[1] openshift/ovn-kubernetes#2663
[2] openshift/ovn-kubernetes@7427c98

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants