Skip to content

RPMs : out of the box defaults #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-bot merged 1 commit into from
Feb 6, 2015
Merged

RPMs : out of the box defaults #922

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions rel-eng/openshift-node.sysconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
ROLE="node"
OPTIONS="--loglevel=0"
# If running node on a separate host please rsync the admin directory ie:
# rsync root@openshift-master:/var/lib/openshift/openshift.local.certificates/admin /var/lib/openshift/openshift.local.certificates/
KUBECONFIG="/var/lib/openshift/openshift.local.certificates/admin/.kubeconfig"
Copy link
Member

@sosiouxme sosiouxme Feb 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This however seems like a good idea, with corresponding node unit change...

Copy link
Member Author

@sdodson sdodson Feb 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KUBECONFIG environment variable is, as far as I can tell, synonymous with --kubeconfig command line switch so it works as is. I was preferring to, whenever possible, use environment variables as it makes the unit file simpler but it's probably confusing to use both environment variables and command line switches.

I was thinking about lobbying for all command line args to work as environment variables as well which would allow us to simplify the unit files. What do you think?

Copy link
Contributor

@dobbymoodge dobbymoodge Feb 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that makes sense. Would it be crazy to suggest that openshift start be able to consume a config file?

Copy link
Contributor

@smarterclayton smarterclayton Feb 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are delaying creating a formal config until the set of required options stabilize. We will support env vars before we support more flags, for sure.

Copy link
Member

@sosiouxme sosiouxme Feb 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure if vars defined in sysconfig actually make it in as env vars given systemd's non-bash expansion of vars. If so, then yeah, much prefer defining env vars to adding cmdline options, until we have a config file.