RPMs : out of the box defaults #922
Conversation
|
@sosiouxme mind taking a look? |
openshift.spec
Outdated
There was a problem hiding this comment.
@sdodson despite what I said earlier, not crazy about doing this. i think @dobbymoodge raised a valid point that if we can't determine a good default, we probably shouldn't put anything at all. taking whatever the hostname is at RPM install time doesn't seem like a good default, and it's hard to think what one could be. The defaults of localhost and NIC IP should already be covered. I think maybe we should stick with not putting --public-master explicitly in the unit/sysconfig file.
|
Removed the commits that set public-master. Everything still works ootb with both rpms installed so long as one attempts to use the console via the ip address rather than a hostname. |
|
do you need this for 0.3.0 beta1? |
|
@smarterclayton yes, this and #930 should really be included in for beta 1 |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/855/) (Image: devenv-fedora_728) |
|
Evaluated for origin up to dc08c3c |
5 participants
This change yields openshift-master and openshift-node configurations that can be run with zero additional configuration assuming that hostname -f is an appropriate hostname for --public-master