Docker registry v2.4.0 #8938

legionus · 2016-05-19T11:46:27Z

Resolves #9491, closes #9284 (hopefully), closes #8596 (hopefully), closes #9122

@pweil- @mfojtik @soltysh @miminar ptal

miminar · 2016-05-19T14:50:17Z

You should bump all the storage driver dependencies as well.

miminar · 2016-05-19T15:18:16Z

Aha, you have them in the vendor/ directory. Not a good place for them. They used to use Godeps dir, didn't they?

miminar · 2016-05-19T15:19:12Z

api/swagger-spec/oapi-v1.json

     }
    ]
   },
-   {


This seem unrelated.

legionus · 2016-05-19T15:41:00Z

yes. I made a mistake :(

miminar · 2016-05-19T15:42:21Z

pkg/dockerregistry/server/repositorymiddleware.go

+	case *schema1.SignedManifest:
+	case *schema2.DeserializedManifest:
+	default:
+		return "", fmt.Errorf("unrecognized manifest type %T", manifest)


Use ErrorCodeManifestInvalid?

smarterclayton · 2016-06-24T17:16:04Z

pkg/dockerregistry/server/tagservice.go

+		return distribution.ErrTagUnknown{Tag: tag}
+	}
+
+	if !t.repo.pullthrough {


Same question as above, who is authorized to make this call?

Similar to the Tag() case. It can be invoked only from imageManifestHandler.DeleteImageManifest(). Not something client can call directly.

Since the docker/distribution has a lot of changes we have to adapt code to use it. * Adapt code to changes in the API. * Add support of Manifest Version 2 Schema 2.

legionus · 2016-06-26T09:51:00Z

@miminar @soltysh @smarterclayton I made changes according to your comments. Please review.

openshift-bot · 2016-06-26T13:35:20Z

Evaluated for origin test up to a536ad1

openshift-bot · 2016-06-26T14:55:08Z

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5435/)

smarterclayton · 2016-06-26T18:32:27Z

Lgtm [merge]

openshift-bot · 2016-06-26T18:35:10Z

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5437/) (Image: devenv-rhel7_4466)

openshift-bot · 2016-06-26T18:35:11Z

Evaluated for origin merge up to a536ad1

0xmichalis · 2016-06-26T21:09:11Z

🎉

mfojtik · 2016-06-26T21:11:25Z

omg :)

Michal Fojtik

On 26 June 2016 at 23:09:11, Michail Kargakis ([email protected])
wrote:

🎉

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#8938 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AACsaEnD3z1nHooL0CR1idRu1iiG0e2Pks5qPup3gaJpZM4IiLYZ
.

legionus · 2016-06-26T21:20:36Z

@Kargakis @mfojtik 🍻

soltysh · 2016-06-27T09:52:26Z

🎉

smarterclayton · 2016-06-28T04:22:42Z

Can you guys summarize the status of the fix to correct the broken tests either here or @ me on which ever issue covers it? Want to have one open so we can track its closure.

miminar · 2016-06-28T07:59:07Z

@smarterclayton Here's the the only issue I know of: #9540, PR with fix is #9582. There's also @liggitt's #9593 which I'll integrete into the former fix PR.

miminar · 2017-03-21T13:16:35Z

Accepting schema 2 may break clients that do not support this schema (docker daemons < 1.10). Apparently, we don't consider it a problem anymore [1]. [1] #13428

…

On 16.3.2017 20:41, Vincent Batts wrote: ***@***.**** commented on this pull request. ------------------------------------------------------------------------------------------------------------------------ In pkg/dockerregistry/server/repositorymiddleware.go <#8938 (comment)>: > @@ -101,9 +104,16 @@ func newRepositoryWithClient(registryClient client.Interface, quotaClient kclien } } - nameParts := strings.SplitN(repo.Name(), "/", 2) + allowSchema2 := true blast from the past. We need version 2 schema 2 support. What is this going to break at this point? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8938 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABaQk3_3nH24sbCo9m8vazq5uwiybIL-ks5rmZBdgaJpZM4IiLYZ>.

dmage · 2017-09-13T22:05:28Z

pkg/image/importer/importer.go

+			imageConfig, err := b.Get(ctx, deserializedManifest.Config.Digest)
+			if err != nil {
+				glog.V(5).Infof("unable to access the image config using digest %q for repository %#v: %#v", d, repository, err)
+				if isDockerError(err, v2.ErrorCodeManifestUnknown) {


@legionus @miminar do you know when it can happen? Looks like dead code for me.

I believe this should be v2.ErrorCodeBlobUnknown.

@dmage basically, we can't be sure that the blob is there. This code is just error handling the Get method. I think it's better than not to handle the error at all.

@miminar yep.

legionus force-pushed the docker-registry-v2.4.0 branch from 20ff4e1 to cdc92b8 Compare May 19, 2016 12:17

miminar reviewed May 19, 2016
View reviewed changes

api/swagger-spec/oapi-v1.json

}

]

},

{

Copy link

miminar May 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seem unrelated.

miminar reviewed May 19, 2016
View reviewed changes

smarterclayton reviewed Jun 24, 2016
View reviewed changes

Use docker/distribution v2.4.0+

ad2e164

Since the docker/distribution has a lot of changes we have to adapt code to use it. * Adapt code to changes in the API. * Add support of Manifest Version 2 Schema 2.

legionus force-pushed the docker-registry-v2.4.0 branch 2 times, most recently from e97eb27 to f655085 Compare June 26, 2016 09:44

legionus force-pushed the docker-registry-v2.4.0 branch from f655085 to 7ab1b84 Compare June 26, 2016 12:18

Fix sti build e2e test

a536ad1

legionus force-pushed the docker-registry-v2.4.0 branch from 7ab1b84 to a536ad1 Compare June 26, 2016 13:34

smarterclayton added api-approved and removed needs-api-review labels Jun 26, 2016

openshift-bot merged commit 8a9252c into openshift:master Jun 26, 2016

legionus mentioned this pull request Jun 26, 2016

Cannot pull from istag referencing image in another repository of internal registry #7792

Closed

miminar mentioned this pull request Jul 7, 2016

Update registry config options openshift/openshift-docs#2473

Merged

legionus mentioned this pull request Aug 24, 2016

Failed to pull docker image due to wrong digest #10555

Closed

vbatts mentioned this pull request Mar 21, 2017

enable registry middleware acceptschema2 #13428

Merged

dmage reviewed Sep 13, 2017

View reviewed changes

Docker registry v2.4.0 #8938

Docker registry v2.4.0 #8938

Uh oh!

Conversation

legionus commented May 19, 2016 • edited by miminar Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miminar commented May 19, 2016

Uh oh!

miminar commented May 19, 2016

Uh oh!

miminar May 19, 2016

Choose a reason for hiding this comment

Uh oh!

legionus commented May 19, 2016

Uh oh!

miminar May 19, 2016

Choose a reason for hiding this comment

Uh oh!

smarterclayton Jun 24, 2016

Choose a reason for hiding this comment

Uh oh!

miminar Jun 26, 2016

Choose a reason for hiding this comment

Uh oh!

legionus commented Jun 26, 2016

Uh oh!

openshift-bot commented Jun 26, 2016

Uh oh!

openshift-bot commented Jun 26, 2016

Uh oh!

smarterclayton commented Jun 26, 2016

Uh oh!

openshift-bot commented Jun 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Jun 26, 2016

Uh oh!

0xmichalis commented Jun 26, 2016

Uh oh!

mfojtik commented Jun 26, 2016

Uh oh!

legionus commented Jun 26, 2016

Uh oh!

soltysh commented Jun 27, 2016

Uh oh!

smarterclayton commented Jun 28, 2016 via email

Uh oh!

miminar commented Jun 28, 2016 • edited by pweil- Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miminar commented Mar 21, 2017 via email

Uh oh!

dmage Sep 13, 2017

Choose a reason for hiding this comment

Uh oh!

miminar Sep 14, 2017

Choose a reason for hiding this comment

Uh oh!

legionus Sep 14, 2017

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

legionus commented May 19, 2016 •

edited by miminar

Loading

openshift-bot commented Jun 26, 2016 •

edited

Loading

miminar commented Jun 28, 2016 •

edited by pweil-

Loading