Skip to content

Conversation

@miminar
Copy link

@miminar miminar commented Jul 7, 2016

Update mandatory config options of registry's config file.

This reflects changes brought by openshift/origin#8938

What else need to be documented (not necessarily in this PR):

  • introduce manifest schema v2
  • make a table of supported configurations of registry version vs docker
    version vs manifest schema version
  • document known issues when deployment or build fails due to pulling of
    manifest schema v2 with docker <1.10
  • explain when it is (un)safe to accept manifest schema v2

@miminar miminar force-pushed the registry-config-2.4.0 branch from a5119f6 to 91c171a Compare July 7, 2016 08:22
@miminar
Copy link
Author

miminar commented Jul 7, 2016

/cc @legionus, @soltysh for technical review

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add a short explanation of this ?

This will help to avoid incompatibilities when using clients docker < 1.10 and docker 1.10 and above at the same time.

@miminar miminar force-pushed the registry-config-2.4.0 branch from 91c171a to 8a9fbac Compare July 7, 2016 15:16
@miminar
Copy link
Author

miminar commented Jul 7, 2016

@soltysh @legionus thanks for the review. I hope I didn't overdo it with verbosity now. Please check it out again.

@legionus
Copy link

legionus commented Jul 7, 2016

LGTM

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/registriy/registry

@soltysh
Copy link

soltysh commented Jul 7, 2016

Nits, overall LGTM. Thank you!

Update mandatory config options of registry's config file.

Signed-off-by: Michal Minar <[email protected]>
@miminar miminar force-pushed the registry-config-2.4.0 branch from 8a9fbac to 5f8091f Compare July 8, 2016 06:40
@miminar
Copy link
Author

miminar commented Jul 8, 2016

Addressed. Thank you all.

/cc @ahardin-rh for making this pleasant to the eye.

@ahardin-rh ahardin-rh added this to the Future Release milestone Jul 8, 2016
@ahardin-rh ahardin-rh self-assigned this Jul 8, 2016
@ahardin-rh
Copy link
Contributor

@miminar always a pleasure! can you please cross-check my labels and milestone before I merge? thanks!

@miminar
Copy link
Author

miminar commented Jul 10, 2016

@ahardin-rh looks good 👍

@ahardin-rh ahardin-rh merged commit 26756e6 into openshift:master Jul 11, 2016
@ahardin-rh
Copy link
Contributor

[rev_history]
|xref:../install_config/install/docker_registry.adoc#install-config-install-docker-registry[Installing -> Deploying a Docker Registry]
|Updated mandatory configuration options for the registry's configuration file.
%

@miminar miminar deleted the registry-config-2.4.0 branch August 5, 2016 14:46
@vikram-redhat vikram-redhat modified the milestones: OCP 3.3 GA, TEMP Oct 7, 2016
@vikram-redhat vikram-redhat modified the milestones: OCP 3.3 GA, TEMP Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants