-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update registry config options #2473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a5119f6 to
91c171a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can add a short explanation of this ?
This will help to avoid incompatibilities when using clients docker < 1.10 and docker 1.10 and above at the same time.
91c171a to
8a9fbac
Compare
|
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/registriy/registry
|
Nits, overall LGTM. Thank you! |
Update mandatory config options of registry's config file. Signed-off-by: Michal Minar <[email protected]>
8a9fbac to
5f8091f
Compare
|
Addressed. Thank you all. /cc @ahardin-rh for making this pleasant to the eye. |
|
@miminar always a pleasure! can you please cross-check my labels and milestone before I merge? thanks! |
|
@ahardin-rh looks good 👍 |
|
[rev_history] |
Update mandatory config options of registry's config file.
This reflects changes brought by openshift/origin#8938
What else need to be documented (not necessarily in this PR):
version vs manifest schema version
manifest schema v2 with docker <1.10