NE-2561: Add Gateway API OLM to NO-OLM migration upgrade test#30897
NE-2561: Add Gateway API OLM to NO-OLM migration upgrade test#30897gcs278 wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci-robot
added
the
jira/valid-reference
|
@gcs278: This pull request references NE-2292 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds a Gateway API upgrade e2e test and registers it in the upgrade suite; the test provisions GatewayClass/Gateway/HTTPRoute, validates provisioning and connectivity before and after upgrades (detects OLM↔NO-OLM migration). Refactors controller helpers for Istio/OSSM checks and replaces echo backend Pod with a Deployment. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
bot
added
the
approved
|
/test e2e-gcp-ovn-upgrade |
|
/test ? |
gcs278
force-pushed
the
gwapi-olm-upgrade-test
branch
from
90dbe8d to
ac9d301
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gcs278 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
bot
removed
the
approved
|
/test e2e-gcp-ovn-upgrade |
gcs278
force-pushed
the
gwapi-olm-upgrade-test
branch
2 times, most recently
from
b08e876 to
4df0775
Compare
|
/test e2e-gcp-ovn-upgrade |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 4df0775
New tests seen in this PR at sha: 4df0775
|
|
/test ? |
|
/payload list |
|
/payload-job periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade |
|
@gcs278: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/60c65dd0-22f9-11f1-91b0-a3e2ef55f2e7-0 |
|
Ah darn this isn't going to work because |
|
@gcs278: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c6220410-2306-11f1-9c3a-90af7c7cc380-0 |
gcs278
force-pushed
the
gwapi-olm-upgrade-test
branch
from
4df0775 to
5b67673
Compare
|
[trying again] Okay, this is a bit crazy, but I created a draft promotion PR (openshift/api#2772) so that we can test with NoOLM as default since we don't have /payload-job-with-prs periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade openshift/api#2772 openshift/cluster-ingress-operator#1354 Additionally, this should still run for OLM to OLM, or noOLM to noOLM (it's a generic z stream upgrade test): This would be noOLM to noOLM: So there's our 3 cases:
|
|
@gcs278: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/23e6af60-2307-11f1-992d-12ede9d2e079-0 |
|
@gcs278: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/26a088fc-2307-11f1-9da4-6bca82f01e76-0 |
|
and the very interesting OLM to noOLM EUS 4.20 to 4.22 update: |
|
@gcs278: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/254dfd70-2ec1-11f1-8462-20ffaf2d891d-0 |
|
/pipeline required |
|
Scheduling required tests: Scheduling tests matching the |
|
/test e2e-vsphere-static-ovn-techpreview |
|
/test e2e-metal-ipi-ovn |
|
Also, might be good to test the OLM to OLM EUS upgrade: /payload-job periodic-ci-openshift-release-main-nightly-4.22-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade-paused |
|
@gcs278: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7f689710-2ec2-11f1-8fa3-1296b4c037a3-0 |
|
Ohh there's a vsphere upgrade from stable job, let's test that from OLM to noOLM |
|
@gcs278: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/215f4c30-2ec3-11f1-976f-5d98aff4f8c1-0 |
|
And vsphere OLM to OLM: |
|
@gcs278: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2f110120-2ec3-11f1-8cc6-443614f15d29-0 |
|
The noOLM to noOLM zstream upgrade didn't start: |
|
/testwith openshift/origin/main/e2e-gcp-ovn-upgrade openshift/api#2772 |
|
@gcs278: This pull request references NE-2561 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
I had claude make a test matrix, because this is getting really confusing:
Test Coverage Explanation
Platform Coverage
|
|
/test e2e-aws-ovn-serial-1of2 |
|
@gcs278: This pull request references NE-2561 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
BareMetal Tests Minor upgrade: OLM → NO-OLM Minor upgrade: OLM → OLM (baseline) |
|
@gcs278: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a0b13bf0-2ec9-11f1-9fc6-7f338c200f2a-0 |
|
opfh that didn't work correctly, it kicked off two of the same "with-prs" despite having two commands (that's probably a bug...): |
|
@gcs278: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d5e6e860-2ec9-11f1-969c-37555de4bfa0-0 |
|
Job Failure Risk Analysis for sha: 9aea19b
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 9aea19b
|
|
Job Failure Risk Analysis for sha: 9aea19b
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 9aea19b
|
|
@CodeRabbit review the links in the table in this comment #30897 (comment) and report back with another table that shows the pass/fail for the tests. Consider a failure that had no Gateway API tests failures introduced or modified in this job, a success for us (we can't fix other failures, but we don't want to introduce new ones). |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chainLet me fetch the test result URLs from the table. 🏁 Script executed: Length of output: 13816 Now let me fetch the actual prow job results for the payload-based runs. 🏁 Script executed: Length of output: 22752 Two AWS EUS runs failed and the BareMetal OLM→NO-OLM run looks suspicious. Let me check the JUnit XML files for Gateway API test results. 🏁 Script executed: Length of output: 15510
Summary: 8 out of 9 runs have no Gateway API failures. The BareMetal OLM→NO-OLM run needs a re-run as the e2e tests never executed due to an infrastructure issue. |
|
other failures and infra issues: |
|
@gcs278: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 9aea19b
|
4 participants
Add upgrade test validating Gateway API migration from OLM-based Istio to CIO-managed Sail Library during 4.21 to 4.22 upgrades.
Setup creates Gateway/HTTPRoute with OLM provisioning and tests connectivity. Test validates migration: Gateway remains programmed, Istiod running, Istio CRDs stay OLM-managed, GatewayClass has CIO finalizer, Istio CR deleted, subscription persists. Teardown cleans up all resources.
Note: While this isn't strictly blocked on noOLM GA promotion (openshift/api#2772), if it merges before it, it will only test OLM --> OLM, and noOLM --> noOLM as TechPreview cannot be upgraded (upgrade CI jobs don't exist for TP).
Commands to Run Complete Test Set
GCP Tests
AWS Tests
vSphere Tests
BareMetal Tests
CC: @rhamini3