NE-2471: Replace OLM-based Istio install with Sail Library#1354
NE-2471: Replace OLM-based Istio install with Sail Library#1354openshift-merge-bot[bot] merged 8 commits intoopenshift:masterfrom
Conversation
|
@gcs278: This pull request references NE-2471 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@gcs278: This pull request references NE-2471 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@gcs278: This pull request references NE-2471 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@gcs278: This pull request references NE-2471 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@gcs278: This pull request references NE-2471 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@gcs278: This pull request references NE-2471 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
22cafc1 to
0a046e5
Compare
0a046e5 to
500e267
Compare
6b0b1af to
8baf8ef
Compare
|
@gcs278: This pull request references NE-2471 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@gcs278: This pull request references NE-2471 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@gcs278: This pull request references NE-2471 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@gcs278: This pull request references NE-2471 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
8baf8ef to
f6b8efd
Compare
|
@gcs278: This pull request references NE-2471 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@gcs278: This pull request references NE-2471 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
manifests/00-cluster-role.yaml
Outdated
| - list | ||
| - watch | ||
|
|
||
| - apiGroups: |
There was a problem hiding this comment.
Is this an Istio requirement @aslakknutsen @gcs278
Can Istio be started without it?
There was a problem hiding this comment.
I'm working on a new version; aslakknutsen/sail-operator@375b004, but basically to allow the library to install some of these for istio to use, the consumer(CIO Operator) has to have the same rbac else we run into escalation issues.
There was a problem hiding this comment.
@rikatz Or are you referring specifically to the x-k8s.io ones?
There was a problem hiding this comment.
I've removed these btw. Sorry I can't remember what this was, but I think it was some experimental APIs. I don't think we need permissions for them.
I reduced the clusterrole to a minimal set for the CIO usage of the sail library. I only added permissions for the new resources created in the Istiod Helm Chart, along with using escalate for clusterroles, so CIO can create an istiod clusterrole with elevated privileges (that's what Sail Operator does today).
f6b8efd to
b0a1817
Compare
|
@gcs278: This pull request references NE-2471 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
b0a1817 to
f972981
Compare
|
Sorry - I think I messed up the last push bump to Aslak's latest changes. But the last push should fix it, and fix a comment in the |
|
/test e2e-aws-operator-techpreview |
|
looked again, looks like just that remaining dep question, which isn't reflective on this PR, so, good to go. |
|
/lgtm |
|
hypershift failure, and unrelated test failure in e2e-azure-operator |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c6220410-2306-11f1-9c3a-90af7c7cc380-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/23e6af60-2307-11f1-992d-12ede9d2e079-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/26a088fc-2307-11f1-9da4-6bca82f01e76-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e01ef8c0-2309-11f1-813c-239011e41911-0 |
| return nil, err | ||
| } | ||
| } else { | ||
| // TODO: Remove this when we switch to an OSSM release branch with proper CSV image annotations. |
|
change lgtm, I am a bit biased because I have some commits there as well, but given Brett came back already and we did a bunch of reviews as well: /lgtm 🚢 |
|
unrelated hypershift failure: |
|
@rhamini3: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0198a9d0-233f-11f1-9a7d-ebebc862b301-0 |
|
Now that openshift/origin#30896 is merged, I'm going to unhold this PR. I'll followed up with QE (@ShudiLi & @lihongan) to recommend an OLM to Sail Library verification; however, since this is TP, I think we have the flexibility to merge this as is and follow up with any issues they may find. The goal is to get this spinning in CI asap. Even with the OLM-logic skips introduced openshift/origin#30896, we are still testing Gateway API ingress mostly end-to-end for Sail Library (minus upgrade tests). When @rhamini3 gets openshift/origin#30905 merged, we will have even better/more precise coverage (and our 5 tests needed for feature gate promotion). We are still using @aslakknutsen's development branch for our sail library, but as a team we decided that's fine for TP. When openshift-service-mesh/sail-operator#721 is merged into /unhold |
|
/retest-required |
|
/override ci/prow/e2e-aws-ovn-hypershift-conformance the hypershit failing tests are all related to cli. The conformance test is permafailing on all other jobs, and we really need this one to be merged. The hypershift team was warned about this error |
|
bot? /override ci/prow/e2e-aws-ovn-hypershift-conformance |
|
@rikatz: Overrode contexts on behalf of rikatz: ci/prow/e2e-aws-ovn-hypershift-conformance DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@rikatz: Overrode contexts on behalf of rikatz: ci/prow/e2e-aws-ovn-hypershift-conformance DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/07dadcd0-2391-11f1-8c59-fe2512e5aad1-0 |
|
Change included in accepted release 4.22.0-0.nightly-2026-03-23-022245 |
Replace OLM-based Istio installation with Sail Library
This PR implements the changes described in the Gateway API without OLM Enhancement to remove the OLM dependency for Gateway API support.
Summary
Adds support for direct Helm chart installation using the sail-operator library (behind the
GatewayAPIWithoutOLMfeature gate). This change:Implementation Details
Sail Library Integration:
GatewayAPIWithoutOLMfeature gate) to deploy istiod directly via Helm with automatic drift detection and repairgo.mod), which embeds charts as resourcesownerReferencefor the Helm chart to enable automatic garbage collectionopenshift.io/ingress-operator-sail-finalizer) to ensure clean Helm uninstall on deletionCRD Management:
ingress.operator.openshift.io/ownedfor ownership trackingInstallation Status:
ControllerInstalled,CRDsReady)RBAC:
00-cluster-role-sail-library.yamland01-cluster-role-binding-sail-library.yaml)Migration:
🚧 TechPreview Notes 🚧:
gcr.io/istio-release(GA will use downstream OSSM images from Red Hat registry)github.com/aslakknutsen/sail-operator) until downstream library is available.User-Facing Improvements
Installation Compatibility:
installPlanApproval: Manualissue in openshift-operators namespace (NE-2224)Functional Behavior:
GatewayClasswith controller nameopenshift.io/gateway-controller/v1Based on proof of concept work in:
TODO
Follow Up (After Merge, but Before GA)
GatewayAPIWithoutOLMfeature gate to get TP CI signal (including upgrade test) (NE-2291)escalatepermission with explicit list of required istiod permissions in ClusterRole (debatable if required for GA) (NE-2518)