OCPNODE-3912: Add a test for NodeSizing default change to OCP 4.20

[ngopalak-redhat]

Fixes #OCPNODE-3912

Summary

This PR introduces a new E2E test case to verify the behavior of the NODE_SIZING_ENABLED feature following the changes in openshift/machine-config-operator#5387. The primary goal is to ensure that while the patch introduces a new MachineConfig, it does not automatically disable a user's ability to enable node autosizing for reserved resources.

NOTE: [Suite:openshift/machine-config-operator/disruptive] will ensure that the container restart failures are not recorded for this test. Its a common pattern used for machine config tests.

Test Steps and Verification

The test case performs the following verifications:

Initial State Check:

A new MachineConfig (related to the patch) is applied.

The test then verifies that, by default, the /etc/node-sizing-enabled.env file on the host still contains NODE_SIZING_ENABLED=false.

Goal: Confirm the new MachineConfig does not inadvertently set this flag to true or prevent it from being set to false.

Enablement Check (Positive Verification):

A KubeletConfig resource is created to enable the auto-sizing reserved feature.

The test verifies that this action successfully overrides the default state and sets NODE_SIZING_ENABLED=true in the /etc/node-sizing-enabled.env file.

Goal: Ensure the MachineConfig patch does not block users from utilizing node autosizing when explicitly configured via KubeletConfig.

Implementation Details

The test utilizes a privileged pod to access the host filesystem (specifically /etc/node-sizing-enabled.env) to directly read the value of the NODE_SIZING_ENABLED environment variable before and after the KubeletConfig application.

This provides robust coverage to prevent a regression where the MCO patch could block or override user-configured autosizing.

Test Result with the PR: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/1987358551382691840/artifacts/launch/openshift-e2e-test/artifacts/e2e.log

Result:

started: 0/22/37 "[Suite:openshift/machine-config-operator/disruptive][Suite:openshift/conformance/serial][Serial][sig-node] Node sizing should have NODE_SIZING_ENABLED=false by default and NODE_SIZING_ENABLED=true when KubeletConfig with autoSizingReserved=true is applied"

passed: (8m14s) 2025-11-28T17:16:32 "[Suite:openshift/machine-config-operator/disruptive][Suite:openshift/conformance/serial][Serial][sig-node] Node sizing should have NODE_SIZING_ENABLED=false by default and NODE_SIZING_ENABLED=true when KubeletConfig with autoSizingReserved=true is applied"

Also to add without the patch the test is passing, which implies that patch does not change the current behavior of 4.20:

passed: (12m39s) 2025-11-09T12:18:00 "[Suite:openshift/conformance/serial][Serial][sig-node] Node sizing should have NODE_SIZING_ENABLED=false by default and NODE_SIZING_ENABLED=true when KubeletConfig with autoSizingReserved=true is applied"

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[ngopalak-redhat]

/test all

[openshift-ci-robot]

@ngopalak-redhat: This pull request references OCPNODE-3722 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@ngopalak-redhat: This pull request references OCPNODE-3722 which is a valid jira issue.

Details

In response to this:

Summary

This PR introduces a new E2E test case to verify the behavior of the NODE_SIZING_ENABLED feature flag following the changes in openshift/machine-config-operator#5387. The primary goal is to ensure that while the patch introduces a new MachineConfig, it does not automatically disable a user's ability to enable node autosizing for reserved resources.

Test Steps and Verification

The test case performs the following verifications:

Initial State Check:

A new MachineConfig (related to the patch) is applied.

The test then verifies that, by default, the /etc/node-sizing-enabled.env file on the host still contains NODE_SIZING_ENABLED=false.

Goal: Confirm the new MachineConfig does not inadvertently set this flag to true or prevent it from being set to false.

Enablement Check (Positive Verification):

A KubeletConfig resource is created to enable the auto-sizing reserved feature.

The test verifies that this action successfully overrides the default state and sets NODE_SIZING_ENABLED=true in the /etc/node-sizing-enabled.env file.

Goal: Ensure the MachineConfig patch does not block users from utilizing node autosizing when explicitly configured via KubeletConfig.

Implementation Details

The test utilizes a privileged pod to access the host filesystem (specifically /etc/node-sizing-enabled.env) to directly read the value of the NODE_SIZING_ENABLED environment variable before and after the KubeletConfig application.

This provides robust coverage to prevent a regression where the MCO patch could block or override user-configured autosizing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ngopalak-redhat]

/retest-required

[openshift-ci-robot]

@ngopalak-redhat: This pull request references OCPNODE-3722 which is a valid jira issue.

Details

In response to this:

Summary

This PR introduces a new E2E test case to verify the behavior of the NODE_SIZING_ENABLED feature flag following the changes in openshift/machine-config-operator#5387. The primary goal is to ensure that while the patch introduces a new MachineConfig, it does not automatically disable a user's ability to enable node autosizing for reserved resources.

Test Steps and Verification

The test case performs the following verifications:

Initial State Check:

A new MachineConfig (related to the patch) is applied.

The test then verifies that, by default, the /etc/node-sizing-enabled.env file on the host still contains NODE_SIZING_ENABLED=false.

Goal: Confirm the new MachineConfig does not inadvertently set this flag to true or prevent it from being set to false.

Enablement Check (Positive Verification):

A KubeletConfig resource is created to enable the auto-sizing reserved feature.

The test verifies that this action successfully overrides the default state and sets NODE_SIZING_ENABLED=true in the /etc/node-sizing-enabled.env file.

Goal: Ensure the MachineConfig patch does not block users from utilizing node autosizing when explicitly configured via KubeletConfig.

Implementation Details

The test utilizes a privileged pod to access the host filesystem (specifically /etc/node-sizing-enabled.env) to directly read the value of the NODE_SIZING_ENABLED environment variable before and after the KubeletConfig application.

This provides robust coverage to prevent a regression where the MCO patch could block or override user-configured autosizing.

Test Result with the PR: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/1987358551382691840/artifacts/launch/openshift-e2e-test/artifacts/e2e.log
Run with clusterBot

test e2e-serial openshift/origin#30467,openshift/machine-config-operator#5387,4.20 aws

Result:

started: 0/60/82 "[Suite:openshift/conformance/serial][Serial][sig-node] Node sizing should have NODE_SIZING_ENABLED=false by default and NODE_SIZING_ENABLED=true when KubeletConfig with autoSizingReserved=true is applied"

passed: (12m44s) 2025-11-09T07:24:02 "[Suite:openshift/conformance/serial][Serial][sig-node] Node sizing should have NODE_SIZING_ENABLED=false by default and NODE_SIZING_ENABLED=true when KubeletConfig with autoSizingReserved=true is applied"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@ngopalak-redhat: This pull request references OCPNODE-3722 which is a valid jira issue.

Details

In response to this:

Summary

This PR introduces a new E2E test case to verify the behavior of the NODE_SIZING_ENABLED feature flag following the changes in openshift/machine-config-operator#5387. The primary goal is to ensure that while the patch introduces a new MachineConfig, it does not automatically disable a user's ability to enable node autosizing for reserved resources.

Test Steps and Verification

The test case performs the following verifications:

Initial State Check:

A new MachineConfig (related to the patch) is applied.

The test then verifies that, by default, the /etc/node-sizing-enabled.env file on the host still contains NODE_SIZING_ENABLED=false.

Goal: Confirm the new MachineConfig does not inadvertently set this flag to true or prevent it from being set to false.

Enablement Check (Positive Verification):

A KubeletConfig resource is created to enable the auto-sizing reserved feature.

The test verifies that this action successfully overrides the default state and sets NODE_SIZING_ENABLED=true in the /etc/node-sizing-enabled.env file.

Goal: Ensure the MachineConfig patch does not block users from utilizing node autosizing when explicitly configured via KubeletConfig.

Implementation Details

The test utilizes a privileged pod to access the host filesystem (specifically /etc/node-sizing-enabled.env) to directly read the value of the NODE_SIZING_ENABLED environment variable before and after the KubeletConfig application.

This provides robust coverage to prevent a regression where the MCO patch could block or override user-configured autosizing.

Test Result with the PR: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/1987358551382691840/artifacts/launch/openshift-e2e-test/artifacts/e2e.log
Run with clusterBot

test e2e-serial openshift/origin#30467,openshift/machine-config-operator#5387,4.20 aws

Result:

started: 0/60/82 "[Suite:openshift/conformance/serial][Serial][sig-node] Node sizing should have NODE_SIZING_ENABLED=false by default and NODE_SIZING_ENABLED=true when KubeletConfig with autoSizingReserved=true is applied"

passed: (12m44s) 2025-11-09T07:24:02 "[Suite:openshift/conformance/serial][Serial][sig-node] Node sizing should have NODE_SIZING_ENABLED=false by default and NODE_SIZING_ENABLED=true when KubeletConfig with autoSizingReserved=true is applied"

Also to add without the patch the test is passing, which implies that patch does not change the current behavior of 4.20:

passed: (12m39s) 2025-11-09T12:18:00 "[Suite:openshift/conformance/serial][Serial][sig-node] Node sizing should have NODE_SIZING_ENABLED=false by default and NODE_SIZING_ENABLED=true when KubeletConfig with autoSizingReserved=true is applied"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ngopalak-redhat]

@haircommander @sairameshv Here's the test for OCP 4.20 for auto-sizing config. It needed not hold on the patch as it tests the existing behavior which the patch should not change.

[ngopalak-redhat]

/retest-required

[openshift-ci-robot]

@ngopalak-redhat: This pull request references OCPNODE-3722 which is a valid jira issue.

Details

In response to this:

Summary

This PR introduces a new E2E test case to verify the behavior of the NODE_SIZING_ENABLED feature flag following the changes in openshift/machine-config-operator#5387. The primary goal is to ensure that while the patch introduces a new MachineConfig, it does not automatically disable a user's ability to enable node autosizing for reserved resources.

NOTE: maxRestartCountForFailures is measured over the ENTIRE test suite run, not at a fixed interval, For this test suite since the node restarts. The count is increased

Test Steps and Verification

The test case performs the following verifications:

Initial State Check:

A new MachineConfig (related to the patch) is applied.

The test then verifies that, by default, the /etc/node-sizing-enabled.env file on the host still contains NODE_SIZING_ENABLED=false.

Goal: Confirm the new MachineConfig does not inadvertently set this flag to true or prevent it from being set to false.

Enablement Check (Positive Verification):

A KubeletConfig resource is created to enable the auto-sizing reserved feature.

The test verifies that this action successfully overrides the default state and sets NODE_SIZING_ENABLED=true in the /etc/node-sizing-enabled.env file.

Goal: Ensure the MachineConfig patch does not block users from utilizing node autosizing when explicitly configured via KubeletConfig.

Implementation Details

The test utilizes a privileged pod to access the host filesystem (specifically /etc/node-sizing-enabled.env) to directly read the value of the NODE_SIZING_ENABLED environment variable before and after the KubeletConfig application.

This provides robust coverage to prevent a regression where the MCO patch could block or override user-configured autosizing.

Test Result with the PR: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/1987358551382691840/artifacts/launch/openshift-e2e-test/artifacts/e2e.log
Run with clusterBot

test e2e-serial openshift/origin#30467,openshift/machine-config-operator#5387,4.20 aws

Result:

started: 0/60/82 "[Suite:openshift/conformance/serial][Serial][sig-node] Node sizing should have NODE_SIZING_ENABLED=false by default and NODE_SIZING_ENABLED=true when KubeletConfig with autoSizingReserved=true is applied"

passed: (12m44s) 2025-11-09T07:24:02 "[Suite:openshift/conformance/serial][Serial][sig-node] Node sizing should have NODE_SIZING_ENABLED=false by default and NODE_SIZING_ENABLED=true when KubeletConfig with autoSizingReserved=true is applied"

Also to add without the patch the test is passing, which implies that patch does not change the current behavior of 4.20:

passed: (12m39s) 2025-11-09T12:18:00 "[Suite:openshift/conformance/serial][Serial][sig-node] Node sizing should have NODE_SIZING_ENABLED=false by default and NODE_SIZING_ENABLED=true when KubeletConfig with autoSizingReserved=true is applied"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ngopalak-redhat]

/test all

[ngopalak-redhat]

/test e2e-aws-ovn-serial-1of2

[ngopalak-redhat]

/test e2e-aws-ovn-serial-1of2

[ngopalak-redhat]

/test e2e-aws-ovn-serial-1of2

[ngopalak-redhat]

/test all

[ngopalak-redhat]

/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2

[haircommander]

/lgtm

[ngopalak-redhat]

/test e2e-aws-ovn-serial-1of2

[ngopalak-redhat]

/test e2e-metal-ipi-ovn-ipv6

[ngopalak-redhat]

/test e2e-aws-ovn-serial-1of2

[openshift-ci]

@ngopalak-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[ngopalak-redhat]

/verified by payload-job

[openshift-ci-robot]

@ngopalak-redhat: This PR has been marked as verified by payload-job.

Details

In response to this:

/verified by payload-job

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ngopalak-redhat]

/assign @stbenjam for review/approval

[openshift-ci-robot]

@ngopalak-redhat: This pull request references Jira Issue OCPBUGS-65777, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Retaining the jira/valid-bug label as it was manually added.

Details

In response to this:

Summary

This PR introduces a new E2E test case to verify the behavior of the NODE_SIZING_ENABLED feature following the changes in openshift/machine-config-operator#5387. The primary goal is to ensure that while the patch introduces a new MachineConfig, it does not automatically disable a user's ability to enable node autosizing for reserved resources.

NOTE: [Suite:openshift/machine-config-operator/disruptive] will ensure that the container restart failures are not recorded for this test. Its a common pattern used for machine config tests.

Test Steps and Verification

The test case performs the following verifications:

Initial State Check:

A new MachineConfig (related to the patch) is applied.

The test then verifies that, by default, the /etc/node-sizing-enabled.env file on the host still contains NODE_SIZING_ENABLED=false.

Goal: Confirm the new MachineConfig does not inadvertently set this flag to true or prevent it from being set to false.

Enablement Check (Positive Verification):

A KubeletConfig resource is created to enable the auto-sizing reserved feature.

The test verifies that this action successfully overrides the default state and sets NODE_SIZING_ENABLED=true in the /etc/node-sizing-enabled.env file.

Goal: Ensure the MachineConfig patch does not block users from utilizing node autosizing when explicitly configured via KubeletConfig.

Implementation Details

The test utilizes a privileged pod to access the host filesystem (specifically /etc/node-sizing-enabled.env) to directly read the value of the NODE_SIZING_ENABLED environment variable before and after the KubeletConfig application.

This provides robust coverage to prevent a regression where the MCO patch could block or override user-configured autosizing.

Test Result with the PR: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/1987358551382691840/artifacts/launch/openshift-e2e-test/artifacts/e2e.log

Result:

started: 0/22/37 "[Suite:openshift/machine-config-operator/disruptive][Suite:openshift/conformance/serial][Serial][sig-node] Node sizing should have NODE_SIZING_ENABLED=false by default and NODE_SIZING_ENABLED=true when KubeletConfig with autoSizingReserved=true is applied"

passed: (8m14s) 2025-11-28T17:16:32 "[Suite:openshift/machine-config-operator/disruptive][Suite:openshift/conformance/serial][Serial][sig-node] Node sizing should have NODE_SIZING_ENABLED=false by default and NODE_SIZING_ENABLED=true when KubeletConfig with autoSizingReserved=true is applied"

Also to add without the patch the test is passing, which implies that patch does not change the current behavior of 4.20:

passed: (12m39s) 2025-11-09T12:18:00 "[Suite:openshift/conformance/serial][Serial][sig-node] Node sizing should have NODE_SIZING_ENABLED=false by default and NODE_SIZING_ENABLED=true when KubeletConfig with autoSizingReserved=true is applied"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@ngopalak-redhat: This pull request references OCPNODE-3720 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.20." or "openshift-4.20.", but it targets "openshift-4.21" instead.

Retaining the jira/valid-bug label as it was manually added.

Details

In response to this:

Summary

This PR introduces a new E2E test case to verify the behavior of the NODE_SIZING_ENABLED feature following the changes in openshift/machine-config-operator#5387. The primary goal is to ensure that while the patch introduces a new MachineConfig, it does not automatically disable a user's ability to enable node autosizing for reserved resources.

NOTE: [Suite:openshift/machine-config-operator/disruptive] will ensure that the container restart failures are not recorded for this test. Its a common pattern used for machine config tests.

Test Steps and Verification

The test case performs the following verifications:

Initial State Check:

A new MachineConfig (related to the patch) is applied.

The test then verifies that, by default, the /etc/node-sizing-enabled.env file on the host still contains NODE_SIZING_ENABLED=false.

Goal: Confirm the new MachineConfig does not inadvertently set this flag to true or prevent it from being set to false.

Enablement Check (Positive Verification):

A KubeletConfig resource is created to enable the auto-sizing reserved feature.

The test verifies that this action successfully overrides the default state and sets NODE_SIZING_ENABLED=true in the /etc/node-sizing-enabled.env file.

Goal: Ensure the MachineConfig patch does not block users from utilizing node autosizing when explicitly configured via KubeletConfig.

Implementation Details

The test utilizes a privileged pod to access the host filesystem (specifically /etc/node-sizing-enabled.env) to directly read the value of the NODE_SIZING_ENABLED environment variable before and after the KubeletConfig application.

This provides robust coverage to prevent a regression where the MCO patch could block or override user-configured autosizing.

Test Result with the PR: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/1987358551382691840/artifacts/launch/openshift-e2e-test/artifacts/e2e.log

Result:

started: 0/22/37 "[Suite:openshift/machine-config-operator/disruptive][Suite:openshift/conformance/serial][Serial][sig-node] Node sizing should have NODE_SIZING_ENABLED=false by default and NODE_SIZING_ENABLED=true when KubeletConfig with autoSizingReserved=true is applied"

passed: (8m14s) 2025-11-28T17:16:32 "[Suite:openshift/machine-config-operator/disruptive][Suite:openshift/conformance/serial][Serial][sig-node] Node sizing should have NODE_SIZING_ENABLED=false by default and NODE_SIZING_ENABLED=true when KubeletConfig with autoSizingReserved=true is applied"

Also to add without the patch the test is passing, which implies that patch does not change the current behavior of 4.20:

passed: (12m39s) 2025-11-09T12:18:00 "[Suite:openshift/conformance/serial][Serial][sig-node] Node sizing should have NODE_SIZING_ENABLED=false by default and NODE_SIZING_ENABLED=true when KubeletConfig with autoSizingReserved=true is applied"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@ngopalak-redhat: This pull request references OCPNODE-3720 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.20." or "openshift-4.20.", but it targets "openshift-4.21" instead.

Retaining the jira/valid-bug label as it was manually added.

Details

In response to this:

Fixes #OCPNODE-3720

Summary

This PR introduces a new E2E test case to verify the behavior of the NODE_SIZING_ENABLED feature following the changes in openshift/machine-config-operator#5387. The primary goal is to ensure that while the patch introduces a new MachineConfig, it does not automatically disable a user's ability to enable node autosizing for reserved resources.

NOTE: [Suite:openshift/machine-config-operator/disruptive] will ensure that the container restart failures are not recorded for this test. Its a common pattern used for machine config tests.

Test Steps and Verification

The test case performs the following verifications:

Initial State Check:

A new MachineConfig (related to the patch) is applied.

The test then verifies that, by default, the /etc/node-sizing-enabled.env file on the host still contains NODE_SIZING_ENABLED=false.

Goal: Confirm the new MachineConfig does not inadvertently set this flag to true or prevent it from being set to false.

Enablement Check (Positive Verification):

A KubeletConfig resource is created to enable the auto-sizing reserved feature.

The test verifies that this action successfully overrides the default state and sets NODE_SIZING_ENABLED=true in the /etc/node-sizing-enabled.env file.

Goal: Ensure the MachineConfig patch does not block users from utilizing node autosizing when explicitly configured via KubeletConfig.

Implementation Details

The test utilizes a privileged pod to access the host filesystem (specifically /etc/node-sizing-enabled.env) to directly read the value of the NODE_SIZING_ENABLED environment variable before and after the KubeletConfig application.

This provides robust coverage to prevent a regression where the MCO patch could block or override user-configured autosizing.

Test Result with the PR: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/1987358551382691840/artifacts/launch/openshift-e2e-test/artifacts/e2e.log

Result:

started: 0/22/37 "[Suite:openshift/machine-config-operator/disruptive][Suite:openshift/conformance/serial][Serial][sig-node] Node sizing should have NODE_SIZING_ENABLED=false by default and NODE_SIZING_ENABLED=true when KubeletConfig with autoSizingReserved=true is applied"

passed: (8m14s) 2025-11-28T17:16:32 "[Suite:openshift/machine-config-operator/disruptive][Suite:openshift/conformance/serial][Serial][sig-node] Node sizing should have NODE_SIZING_ENABLED=false by default and NODE_SIZING_ENABLED=true when KubeletConfig with autoSizingReserved=true is applied"

Also to add without the patch the test is passing, which implies that patch does not change the current behavior of 4.20:

passed: (12m39s) 2025-11-09T12:18:00 "[Suite:openshift/conformance/serial][Serial][sig-node] Node sizing should have NODE_SIZING_ENABLED=false by default and NODE_SIZING_ENABLED=true when KubeletConfig with autoSizingReserved=true is applied"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ngopalak-redhat]

/jira refresh

[openshift-ci-robot]

@ngopalak-redhat: This pull request references OCPNODE-3720 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target only the "4.20.z" version, but multiple target versions were set.

Retaining the jira/valid-bug label as it was manually added.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@ngopalak-redhat: This pull request references OCPNODE-3912 which is a valid jira issue.

Retaining the jira/valid-bug label as it was manually added.

Details

In response to this:

Fixes #OCPNODE-3720

Summary

This PR introduces a new E2E test case to verify the behavior of the NODE_SIZING_ENABLED feature following the changes in openshift/machine-config-operator#5387. The primary goal is to ensure that while the patch introduces a new MachineConfig, it does not automatically disable a user's ability to enable node autosizing for reserved resources.

NOTE: [Suite:openshift/machine-config-operator/disruptive] will ensure that the container restart failures are not recorded for this test. Its a common pattern used for machine config tests.

Test Steps and Verification

The test case performs the following verifications:

Initial State Check:

A new MachineConfig (related to the patch) is applied.

The test then verifies that, by default, the /etc/node-sizing-enabled.env file on the host still contains NODE_SIZING_ENABLED=false.

Goal: Confirm the new MachineConfig does not inadvertently set this flag to true or prevent it from being set to false.

Enablement Check (Positive Verification):

A KubeletConfig resource is created to enable the auto-sizing reserved feature.

The test verifies that this action successfully overrides the default state and sets NODE_SIZING_ENABLED=true in the /etc/node-sizing-enabled.env file.

Goal: Ensure the MachineConfig patch does not block users from utilizing node autosizing when explicitly configured via KubeletConfig.

Implementation Details

The test utilizes a privileged pod to access the host filesystem (specifically /etc/node-sizing-enabled.env) to directly read the value of the NODE_SIZING_ENABLED environment variable before and after the KubeletConfig application.

This provides robust coverage to prevent a regression where the MCO patch could block or override user-configured autosizing.

Test Result with the PR: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/1987358551382691840/artifacts/launch/openshift-e2e-test/artifacts/e2e.log

Result:

started: 0/22/37 "[Suite:openshift/machine-config-operator/disruptive][Suite:openshift/conformance/serial][Serial][sig-node] Node sizing should have NODE_SIZING_ENABLED=false by default and NODE_SIZING_ENABLED=true when KubeletConfig with autoSizingReserved=true is applied"

passed: (8m14s) 2025-11-28T17:16:32 "[Suite:openshift/machine-config-operator/disruptive][Suite:openshift/conformance/serial][Serial][sig-node] Node sizing should have NODE_SIZING_ENABLED=false by default and NODE_SIZING_ENABLED=true when KubeletConfig with autoSizingReserved=true is applied"

Also to add without the patch the test is passing, which implies that patch does not change the current behavior of 4.20:

passed: (12m39s) 2025-11-09T12:18:00 "[Suite:openshift/conformance/serial][Serial][sig-node] Node sizing should have NODE_SIZING_ENABLED=false by default and NODE_SIZING_ENABLED=true when KubeletConfig with autoSizingReserved=true is applied"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@ngopalak-redhat: This pull request references OCPNODE-3912 which is a valid jira issue.

Retaining the jira/valid-bug label as it was manually added.

Details

In response to this:

Fixes #OCPNODE-3912

Summary

This PR introduces a new E2E test case to verify the behavior of the NODE_SIZING_ENABLED feature following the changes in openshift/machine-config-operator#5387. The primary goal is to ensure that while the patch introduces a new MachineConfig, it does not automatically disable a user's ability to enable node autosizing for reserved resources.

NOTE: [Suite:openshift/machine-config-operator/disruptive] will ensure that the container restart failures are not recorded for this test. Its a common pattern used for machine config tests.

Test Steps and Verification

The test case performs the following verifications:

Initial State Check:

A new MachineConfig (related to the patch) is applied.

The test then verifies that, by default, the /etc/node-sizing-enabled.env file on the host still contains NODE_SIZING_ENABLED=false.

Goal: Confirm the new MachineConfig does not inadvertently set this flag to true or prevent it from being set to false.

Enablement Check (Positive Verification):

A KubeletConfig resource is created to enable the auto-sizing reserved feature.

The test verifies that this action successfully overrides the default state and sets NODE_SIZING_ENABLED=true in the /etc/node-sizing-enabled.env file.

Goal: Ensure the MachineConfig patch does not block users from utilizing node autosizing when explicitly configured via KubeletConfig.

Implementation Details

The test utilizes a privileged pod to access the host filesystem (specifically /etc/node-sizing-enabled.env) to directly read the value of the NODE_SIZING_ENABLED environment variable before and after the KubeletConfig application.

This provides robust coverage to prevent a regression where the MCO patch could block or override user-configured autosizing.

Test Result with the PR: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/1987358551382691840/artifacts/launch/openshift-e2e-test/artifacts/e2e.log

Result:

started: 0/22/37 "[Suite:openshift/machine-config-operator/disruptive][Suite:openshift/conformance/serial][Serial][sig-node] Node sizing should have NODE_SIZING_ENABLED=false by default and NODE_SIZING_ENABLED=true when KubeletConfig with autoSizingReserved=true is applied"

passed: (8m14s) 2025-11-28T17:16:32 "[Suite:openshift/machine-config-operator/disruptive][Suite:openshift/conformance/serial][Serial][sig-node] Node sizing should have NODE_SIZING_ENABLED=false by default and NODE_SIZING_ENABLED=true when KubeletConfig with autoSizingReserved=true is applied"

Also to add without the patch the test is passing, which implies that patch does not change the current behavior of 4.20:

passed: (12m39s) 2025-11-09T12:18:00 "[Suite:openshift/conformance/serial][Serial][sig-node] Node sizing should have NODE_SIZING_ENABLED=false by default and NODE_SIZING_ENABLED=true when KubeletConfig with autoSizingReserved=true is applied"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ngopalak-redhat]

/assign @stbenjam
for review/approval

[neisw]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, neisw, ngopalak-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [neisw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment