Skip to content

Conversation

@liouk
Copy link
Member

@liouk liouk commented Aug 12, 2025

When OIDC is configured, the console-operator needs a valid OIDC client config (including a client secret) in the authentication CR in .spec.oidcProviders[].oidcClients in order to configure the Console properly for OIDC. If that config is not present there, or if the secret is missing or does not contain data, the operator will go Degraded.

While setting an OIDC client is not required by the API, we must avoid breaking the cluster operator monitor tests that require operators to not go degraded during an e2e test.

Therefore this PR adds a valid OIDC secret and client configuration for the console-operator to consume.

This PR also includes a small refactoring; all test-specific resources now reuse the same random ID in order to make it easier to distinguish separate test runs in logs or while debugging.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 12, 2025
@openshift-ci-robot
Copy link

@liouk: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2025
@openshift-ci openshift-ci bot requested review from deads2k and ibihim August 12, 2025 10:37
@liouk liouk force-pushed the oidc-client-secret branch from a25e9eb to aca3a7f Compare August 12, 2025 13:18
@liouk liouk changed the title WIP: NO-JIRA: oidc: configure an oidc client secret for the console to consume WIP: CNTRLPLANE-945: oidc: configure an oidc client secret for the console to consume Aug 12, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 12, 2025

@liouk: This pull request references CNTRLPLANE-945 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

When OIDC is configured, the console-operator needs a valid OIDC client config (including a client secret) in the authentication CR in .spec.oidcProviders[].oidcClients in order to configure the Console properly for OIDC. If that config is not present there, or if the secret is missing or does not contain data, the operator will go Degraded.

While setting an OIDC client is not required by the API, we must avoid breaking the cluster operator monitor tests that require operators to not go degraded during an e2e test.

Therefore this PR adds a valid OIDC secret and client configuration for the console-operator to consume.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@liouk liouk force-pushed the oidc-client-secret branch from aca3a7f to b9883a3 Compare August 12, 2025 15:27
@liouk liouk changed the title WIP: CNTRLPLANE-945: oidc: configure an oidc client secret for the console to consume CNTRLPLANE-945: oidc: configure an oidc client secret for the console to consume Aug 12, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 12, 2025

@liouk: This pull request references CNTRLPLANE-945 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

When OIDC is configured, the console-operator needs a valid OIDC client config (including a client secret) in the authentication CR in .spec.oidcProviders[].oidcClients in order to configure the Console properly for OIDC. If that config is not present there, or if the secret is missing or does not contain data, the operator will go Degraded.

While setting an OIDC client is not required by the API, we must avoid breaking the cluster operator monitor tests that require operators to not go degraded during an e2e test.

Therefore this PR adds a valid OIDC secret and client configuration for the console-operator to consume.

This PR also includes a small refactoring; all test-specific resources now reuse the same random ID in order to make it easier to distinguish separate test runs in logs or while debugging.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kevinrizza
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2025
@sjenning sjenning added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8854246 and 2 for PR HEAD b9883a3 in total

@kevinrizza
Copy link
Member

/retest-required

1 similar comment
@liouk
Copy link
Member Author

liouk commented Aug 13, 2025

/retest-required

@liouk
Copy link
Member Author

liouk commented Aug 13, 2025

/test e2e-aws-ovn-edge-zones

@liouk liouk force-pushed the oidc-client-secret branch from b9883a3 to dbdacbb Compare August 13, 2025 14:06
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2025
@kevinrizza
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: kevinrizza, liouk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0dc595f and 2 for PR HEAD dbdacbb in total

@sdodson sdodson merged commit 1020239 into openshift:main Aug 13, 2025
29 of 47 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 13, 2025

@liouk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-cgroupsv2 dbdacbb link false /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-gcp-ovn-techpreview dbdacbb link false /test e2e-gcp-ovn-techpreview
ci/prow/e2e-azure dbdacbb link false /test e2e-azure
ci/prow/e2e-aws-ovn-kube-apiserver-rollout dbdacbb link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-metal-ipi-virtualmedia dbdacbb link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-openstack-ovn dbdacbb link false /test e2e-openstack-ovn
ci/prow/e2e-aws-proxy dbdacbb link false /test e2e-aws-proxy
ci/prow/okd-scos-e2e-aws-ovn dbdacbb link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants