-
Notifications
You must be signed in to change notification settings - Fork 4.8k
CNTRLPLANE-945: oidc: configure an oidc client secret for the console to consume #30094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@liouk: This pull request explicitly references no jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
a25e9eb to
aca3a7f
Compare
|
@liouk: This pull request references CNTRLPLANE-945 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
aca3a7f to
b9883a3
Compare
|
@liouk: This pull request references CNTRLPLANE-945 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/test e2e-aws-ovn-edge-zones |
b9883a3 to
dbdacbb
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: kevinrizza, liouk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@liouk: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
When OIDC is configured, the console-operator needs a valid OIDC client config (including a client secret) in the authentication CR in
.spec.oidcProviders[].oidcClientsin order to configure the Console properly for OIDC. If that config is not present there, or if the secret is missing or does not contain data, the operator will go Degraded.While setting an OIDC client is not required by the API, we must avoid breaking the cluster operator monitor tests that require operators to not go degraded during an e2e test.
Therefore this PR adds a valid OIDC secret and client configuration for the console-operator to consume.
This PR also includes a small refactoring; all test-specific resources now reuse the same random ID in order to make it easier to distinguish separate test runs in logs or while debugging.