NE-2031: Enhancing the gateway controller test cases with two more function #29806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Contributor
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Contributor
Author
|
Contributor
Author
|
melvinjoseph86
force-pushed
the
gatewaycontroller_enh-new
branch
from
e5ca552 to
d9e0994
Compare
alebedev87
approved these changes
May 16, 2025
Contributor
alebedev87
left a comment
alebedev87
left a comment
There was a problem hiding this comment.
Same PR as the one I already LGTMed.
Contributor
|
/lgtm |
Contributor
Author
|
/assign @deads2k |
Contributor
|
/approve |
openshift-ci
bot
added
the
approved
openshift-merge-robot
added
the
needs-rebase
|
Job Failure Risk Analysis for sha: d9e0994
|
openshift-merge-robot
removed
the
needs-rebase
Contributor
Author
|
Rebased due to a merge conflict with 29784 |
Contributor
Author
|
@alebedev87 Kindly again provide me the lgtm label, this time one more rebase issue came up. |
|
Job Failure Risk Analysis for sha: 32e42c3
|
Contributor
Author
|
/retest-required |
1 similar comment
Contributor
Author
|
/retest-required |
melvinjoseph86
changed the title
|
@melvinjoseph86: This pull request references NE-2031 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
/lgtm Thanks @melvinjoseph86! |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87, melvinjoseph86, neisw The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/retest-required |
Contributor
|
/test e2e-metal-ipi-serial |
Contributor
|
@lihongan: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
|
/retest |
Contributor
Author
|
/retest-required |
Contributor
Author
|
/test e2e-metal-ipi-serial |
Contributor
|
@melvinjoseph86: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
Author
|
/retest |
Contributor
Author
|
/test e2e-metal-ipi-serial |
Contributor
|
@melvinjoseph86: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Member
|
/skip |
|
Job Failure Risk Analysis for sha: 868d90c
|
|
Job Failure Risk Analysis for sha: 868d90c
|
Contributor
Author
|
/retest-required |
|
Job Failure Risk Analysis for sha: 868d90c
|
Contributor
|
@melvinjoseph86: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: 868d90c
|
|
Job Failure Risk Analysis for sha: 868d90c
|
Contributor
Author
|
/retest-required |
|
Job Failure Risk Analysis for sha: 868d90c
|
openshift-merge-bot
bot
merged commit 57e5a5c
into
openshift:main
53 of 63 checks passed
Contributor
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the enhancement of gatewayapicontroller test cases we need to add a function 'AdminIngressClient' in util/client.go which will be used in accessing the gateway DNS records. This addition causes the bumping vendor dependencies in this commit.
JIRA: https://issues.redhat.com/browse/NE-2031
Adding two more function:-
assertDNSRecordStatus - assertDNSRecordStatus polls until the DNSRecord's status in the default operand namespace is True.
assertHttpRouteConnection - assertHttpRouteConnection checks if the http route of the given name replies successfully, and returns an error if not