-
Notifications
You must be signed in to change notification settings - Fork 4.8k
NE-2031: Enhancing the gateway controller test cases with two more function #29703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NE-2031: Enhancing the gateway controller test cases with two more function #29703
Conversation
|
Skipping CI for Draft Pull Request. |
|
/test e2e-gcp-ovn-techpreview |
|
/test e2e-aws-ovn-single-node-techpreview |
|
/test all |
|
/test e2e-gcp-ovn-techpreview |
|
/test e2e-gcp-ovn-techpreview |
|
/retest-required |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-techpreview periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-dualstack-techpreview periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6-techpreview periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview periodic-ci-openshift-multiarch-master-nightly-4.19-ocp-e2e-aws-ovn-techpreview-multi-a-a periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ipi-ovn-runc-techpreview |
|
@melvinjoseph86: trigger 6 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b24832f0-20de-11f0-9d6e-86ea7a2c6e88-0 |
|
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview |
|
@melvinjoseph86: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/40113230-20df-11f0-9754-43ec7977072b-0 |
|
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview |
|
@melvinjoseph86: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6f1c1f10-20ec-11f0-89a4-d0208a4749ba-0 |
|
/retest-required |
|
/retest-required |
|
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview |
|
@melvinjoseph86: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6adee4f0-2178-11f0-9d83-600eabcaefaa-0 |
|
Job Failure Risk Analysis for sha: 9d11a79
|
|
/assign |
|
Job Failure Risk Analysis for sha: 7b39cea
|
|
/retest-required |
7b39cea to
94ac316
Compare
|
/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-dualstack periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6 periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn periodic-ci-openshift-multiarch-master-nightly-4.19-ocp-e2e-aws-ovn-multi-a-a periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ipi-ovn-runc |
|
@melvinjoseph86: trigger 5 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1522d3e0-3164-11f0-9b55-ca6bf5b76be5-0 |
|
/lgtm |
|
/retest-required |
|
Job Failure Risk Analysis for sha: 94ac316
|
|
/test e2e-aws-disruptive |
|
/payload-job periodic-ci-openshift-multiarch-master-nightly-4.19-ocp-e2e-aws-ovn-techpreview-multi-a-a |
|
@melvinjoseph86: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/34c77f30-318b-11f0-96b4-f8cb3f302c1b-0 |
|
/assign @sosiouxme @deads2k |
|
@melvinjoseph86: GitHub didn't allow me to assign the following users: soltysh. Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Job Failure Risk Analysis for sha: 94ac316
|
94ac316 to
71388ce
Compare
|
New changes are detected. LGTM label has been removed. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alebedev87, melvinjoseph86 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
71388ce to
067d8b1
Compare
|
/close |
|
@melvinjoseph86: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@melvinjoseph86: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
For the enhancement of gatewayapicontroller test cases we need to add a function 'AdminIngressClient' in util/client.go which will be used in accessing the gateway DNS records. This addition causes the bumping vendor dependencies in this commit.
JIRA: https://issues.redhat.com/browse/NE-2031
Adding two more function:-
assertDNSRecordStatus - assertDNSRecordStatus polls until the DNSRecord's status in the default operand namespace is True.
assertHttpRouteConnection - assertHttpRouteConnection checks if the http route of the given name replies successfully, and returns an error if not
Runner logs:-