Skip to content

Conversation

@xueqzhan
Copy link
Contributor

@xueqzhan xueqzhan commented Nov 18, 2024

Reverts #29290 ; tracked by https://issues.redhat.com/browse/OCPBUGS-44662

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This change is breaking 4.18 nightly. First payload failure https://amd64.ocp.releases.ci.openshift.org/releasestream/4.18.0-0.nightly/release/4.18.0-0.nightly-2024-11-16-132904

See thread for more details: https://redhat-internal.slack.com/archives/C01CQA76KMX/p1731937499008099?thread_ts=1731522911.671799&cid=C01CQA76KMX

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of (job/X or job/X, test/Y tuple) to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-techpreview-serial

CC: @tmshort @joelanford

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 18, 2024
@openshift-ci-robot
Copy link

@xueqzhan: This pull request explicitly references no jira issue.

Details

In response to this:

TRT has unfortunately had to revert this breaking change to get CI and/or nightly payloads flowing again.

The original PR was #29290.

To restore your change, create a new PR that reverts the revert and layers additional separate commit(s) on top that addresses the problem.

Contact information for TRT is available at https://source.redhat.com/groups/public/atomicopenshift/atomicopenshift_wiki/how_to_contact_the_technical_release_team. Please reach out if you need assistance in relanding your change or have feedback about this process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2024
@stbenjam
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stbenjam
Copy link
Member

/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-microshift
/override ci/prow/e2e-metal-ipi-ovn
/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-csi
/override ci/prow/e2e-aws-ovn-edge-zones
/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-agnostic-ovn-cmd
/override ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-aws-ovn-single-node-upgrade
/override ci/prow/e2e-aws-ovn-cgroupsv2
/override ci/prow/e2e-openstack-ovn
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-aws-ovn-single-node-serial
/override ci/prow/e2e-aws-ovn-microshift-serial
/override ci/prow/e2e-aws-ovn-kube-apiserver-rollout
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/okd-scos-e2e-aws-ovn
/override ci/prow/e2e-gcp-ovn-rt-upgrade
/skip

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2024

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-agnostic-ovn-cmd, ci/prow/e2e-aws-csi, ci/prow/e2e-aws-ovn-cgroupsv2, ci/prow/e2e-aws-ovn-edge-zones, ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-kube-apiserver-rollout, ci/prow/e2e-aws-ovn-microshift, ci/prow/e2e-aws-ovn-microshift-serial, ci/prow/e2e-aws-ovn-serial, ci/prow/e2e-aws-ovn-single-node, ci/prow/e2e-aws-ovn-single-node-serial, ci/prow/e2e-aws-ovn-single-node-upgrade, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-gcp-csi, ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-rt-upgrade, ci/prow/e2e-gcp-ovn-upgrade, ci/prow/e2e-metal-ipi-ovn, ci/prow/e2e-metal-ipi-ovn-ipv6, ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout, ci/prow/e2e-openstack-ovn, ci/prow/okd-scos-e2e-aws-ovn

Details

In response to this:

/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-microshift
/override ci/prow/e2e-metal-ipi-ovn
/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-csi
/override ci/prow/e2e-aws-ovn-edge-zones
/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-agnostic-ovn-cmd
/override ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-aws-ovn-single-node-upgrade
/override ci/prow/e2e-aws-ovn-cgroupsv2
/override ci/prow/e2e-openstack-ovn
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-aws-ovn-single-node-serial
/override ci/prow/e2e-aws-ovn-microshift-serial
/override ci/prow/e2e-aws-ovn-kube-apiserver-rollout
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/okd-scos-e2e-aws-ovn
/override ci/prow/e2e-gcp-ovn-rt-upgrade
/skip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@joelanford
Copy link
Member

/test e2e-gcp-ovn-techpreview

@stbenjam
Copy link
Member

stbenjam commented Nov 18, 2024

/override ci/prow/e2e-gcp-ovn-techpreview

We're returning the tests to a previously working state (actually all skipped) so don't think it's necessary

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2024

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-gcp-ovn-techpreview

Details

In response to this:

/override ci/prow/e2e-gcp-ovn-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stbenjam
Copy link
Member

/override ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2024

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout

Details

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 6fdaf6b into openshift:master Nov 18, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2024

@xueqzhan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.19.0-202411181637.p0.g6fdaf6b.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants