Skip to content

OCPBUGS-32293: Update Jenkins test to use Deployment #28718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
apoorvajagtap wants to merge 2 commits into from
Closed

OCPBUGS-32293: Update Jenkins test to use Deployment #28718

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
809e832
skips jenkins pipeline build config strategy test
apoorvajagtap Apr 17, 2024
ba2a8f0
replaces deploymentconfig with deployment
apoorvajagtap Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/extended/builds/pipeline_origin_bld.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ var _ = g.Describe("[sig-builds][Feature:JenkinsRHELImagesOnly][Feature:Jenkins]
o.Expect(err).NotTo(o.HaveOccurred())

g.By("waiting for jenkins deployment")
err = exutil.WaitForDeploymentConfig(oc.KubeClient(), oc.AppsClient().AppsV1(), oc.Namespace(), "jenkins", 1, false, oc)
err = exutil.WaitForDeploymentReady(oc, "jenkins", oc.Namespace())

@sanchezl sanchezl Apr 18, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In WaitForDeploymentReady, the context isn't wired through to the PollUntilContextTimeout's ConditionFunc. No rush to fix it now if the test is working, but FYI.

if err != nil {
exutil.DumpApplicationPodLogs("jenkins", oc)
}
Expand Down