Skip to content

USHIFT-1379: skip must-gather tests for MicroShift #28015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2023
Merged

USHIFT-1379: skip must-gather tests for MicroShift #28015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b96816f
USHIFT-1379: skip must-gather tests for MicroShift
chiragkyal Jun 30, 2023
df93fe3
USHIFT-1379: add [apigroup:config.openshift.io] annotation to skip tests
chiragkyal Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/extended/cli/mustgather.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ var _ = g.Describe("[sig-cli] oc adm must-gather", func() {
o.Expect(err).NotTo(o.HaveOccurred())
})

g.It("runs successfully", func() {
g.It("runs successfully [apigroup:config.openshift.io]", func() {
controlPlaneTopology, err := exutil.GetControlPlaneTopology(oc)
o.Expect(err).NotTo(o.HaveOccurred())
if *controlPlaneTopology == configv1.ExternalTopologyMode {
Expand Down Expand Up @@ -101,7 +101,7 @@ var _ = g.Describe("[sig-cli] oc adm must-gather", func() {
}
})

g.It("runs successfully with options", func() {
g.It("runs successfully with options [apigroup:config.openshift.io]", func() {
controlPlaneTopology, err := exutil.GetControlPlaneTopology(oc)
o.Expect(err).NotTo(o.HaveOccurred())
if *controlPlaneTopology == configv1.ExternalTopologyMode {
Expand Down Expand Up @@ -299,7 +299,7 @@ var _ = g.Describe("[sig-cli] oc adm must-gather", func() {
}
})

g.When("looking at the audit logs", func() {
g.When("looking at the audit logs [apigroup:config.openshift.io]", func() {
g.Describe("[sig-node] kubelet", func() {
g.It("runs apiserver processes strictly sequentially in order to not risk audit log corruption", func() {
controlPlaneTopology, err := exutil.GetControlPlaneTopology(oc)
Expand Down
8 changes: 4 additions & 4 deletions test/extended/util/annotate/generated/zz_generated.annotations.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.