Skip to content

USHIFT-1379: skip must-gather tests for MicroShift #28015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 9, 2023
Merged

USHIFT-1379: skip must-gather tests for MicroShift #28015

merged 2 commits into from
Jul 9, 2023

Conversation

@chiragkyal
Copy link
Member

@chiragkyal chiragkyal commented Jun 30, 2023

As oc adm must-gather is not supported in MicroShift, these tests can be skipped.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 30, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 30, 2023 •
edited by openshift-ci bot
Loading

@chiragkyal: This pull request references USHIFT-1379 which is a valid jira issue.

In response to this:

As oc adm must-gather is not supported in MicroShift, these tests can be skipped.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

pacevedom
pacevedom reviewed Jul 3, 2023
View reviewed changes
test/extended/cli/mustgather.go Outdated
oc := exutil.NewCLI("oc-adm-must-gather").AsAdmin()

g.BeforeEach(func() {
isMicroShift, err := exutil.IsMicroShiftCluster(oc)
Copy link
Contributor

@pacevedom pacevedom Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must-gather uses many OCP apigroups not present in microshift, is it better to annotate the tests instead?

Copy link
Member Author

@chiragkyal chiragkyal Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that can be a better approach. I've added [apigroup:config.openshift.io] in these tests, please let me know if this looks good. Thanks!

@chiragkyal chiragkyal marked this pull request as ready for review July 3, 2023 11:13
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2023
@openshift-ci openshift-ci bot requested review from csrwng and jmguzik July 3, 2023 11:14
@dhellmann
Copy link
Contributor

dhellmann commented Jul 3, 2023

/retest-required
/lgtm

Using the config API group makes sense as an indicator that this test is tied to OpenShift.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2023
@chiragkyal
Copy link
Member Author

chiragkyal commented Jul 4, 2023

/retest

pacevedom
pacevedom reviewed Jul 4, 2023
View reviewed changes
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@chiragkyal
Copy link
Member Author

chiragkyal commented Jul 4, 2023

/assign @soltysh

@dhellmann
Copy link
Contributor

dhellmann commented Jul 6, 2023

/retest

soltysh
soltysh approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chiragkyal, dhellmann, pacevedom, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 6, 2023

/retest-required

Remaining retests: 0 against base HEAD 23cab2d and 2 for PR HEAD df93fe3 in total

@chiragkyal
Copy link
Member Author

chiragkyal commented Jul 7, 2023

/retest-required

2 similar comments
@chiragkyal
Copy link
Member Author

chiragkyal commented Jul 7, 2023

/retest-required

@chiragkyal
Copy link
Member Author

chiragkyal commented Jul 7, 2023

/retest-required

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 7, 2023

/retest-required

Remaining retests: 0 against base HEAD 588f84b and 1 for PR HEAD df93fe3 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 7, 2023

/retest-required

Remaining retests: 0 against base HEAD e0aea0e and 0 for PR HEAD df93fe3 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2023 •
edited
Loading

@chiragkyal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade df93fe3 link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-single-node df93fe3 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-single-node-serial df93fe3 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node-upgrade df93fe3 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 7, 2023

/hold

Revision df93fe3 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2023
@chiragkyal
Copy link
Member Author

chiragkyal commented Jul 8, 2023

/retest-required

@chiragkyal
Copy link
Member Author

chiragkyal commented Jul 9, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2023
@openshift-merge-robot openshift-merge-robot merged commit da68070 into openshift:master Jul 9, 2023
@chiragkyal chiragkyal deleted the USHIFT-1379 branch July 10, 2023 05:14
machine424 added a commit to machine424/origin that referenced this pull request Aug 14, 2025
@machine424
require [apigroup:config.openshift.io] so the test doesn't run on
2d614d1 
microshift as "oc adm must-gather" isn't supported there.

this was done for other tests in openshift#28015
wangke19 pushed a commit to wangke19/origin that referenced this pull request Oct 16, 2025
@machine424 @wangke19
require [apigroup:config.openshift.io] so the test doesn't run on
96130b1 
microshift as "oc adm must-gather" isn't supported there.

this was done for other tests in openshift#28015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@jmguzik jmguzik Awaiting requested review from jmguzik

2 more reviewers

@pacevedom pacevedom pacevedom left review comments

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dhellmann dhellmann

@soltysh soltysh

@pacevedom pacevedom

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@chiragkyal @openshift-ci-robot @dhellmann @soltysh @pacevedom @openshift-merge-robot