Skip to content

Unrevert websocket SCC exec test with skip for clusters reachable via HTTP proxy.#27951

Closed
benluddy wants to merge 2 commits intoopenshift:masterfrom
benluddy:sccexec-get-test-skip-proxied
Closed

Unrevert websocket SCC exec test with skip for clusters reachable via HTTP proxy.#27951
benluddy wants to merge 2 commits intoopenshift:masterfrom
benluddy:sccexec-get-test-skip-proxied

Conversation

@benluddy
Copy link
Contributor

@benluddy benluddy commented May 26, 2023 •
edited
Loading

Unrevert of #27943.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@benluddy
Copy link
Contributor Author

benluddy commented May 26, 2023

/payload-job metal-ipi-ovn-ipv6
/payload-job metal-ipi-sdn-bm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2023

@benluddy: trigger 0 job(s) for the /payload-(job|aggregate) command

@benluddy
Copy link
Contributor Author

benluddy commented May 26, 2023

/payload-job periodic-ci-openshift-release-master-nightly-4.14-e2e-metal-ipi-ovn-ipv6
/payload-job periodic-ci-openshift-release-master-nightly-4.14-e2e-metal-ipi-sdn-bm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2023

@benluddy: trigger 2 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-nightly-4.14-e2e-metal-ipi-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.14-e2e-metal-ipi-sdn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b6cde380-fbcc-11ed-82f8-50acda3799b7-0

@benluddy benluddy marked this pull request as ready for review June 22, 2023 17:28
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 22, 2023
@openshift-ci openshift-ci bot requested review from deads2k and sosiouxme June 22, 2023 17:28
benluddy added 2 commits June 22, 2023 13:37
@benluddy
Revert "Revert "Add coverage for GET verb and websocket handshake to …
d13d880 
…SCC exec tests.""

This reverts commit 8a19317.
@benluddy
Skip websocket SCC exec test if accessing cluster via proxy.
67029f3 
The client from x/net/websocket doesn't support HTTP proxies. Several
upstream tests using websockets have the same limitation.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2023

@benluddy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-serial f3470f4 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-gcp-csi f3470f4 link false /test e2e-gcp-csi
ci/prow/e2e-aws-ovn-upgrade f3470f4 link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-csi f3470f4 link false /test e2e-aws-csi
ci/prow/e2e-aws-ovn-single-node f3470f4 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-gcp-ovn f3470f4 link true /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-serial f3470f4 link true /test e2e-aws-ovn-serial
ci/prow/unit f3470f4 link true /test unit
ci/prow/lint f3470f4 link true /test lint
ci/prow/verify f3470f4 link true /test verify
ci/prow/e2e-gcp-ovn-upgrade f3470f4 link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-agnostic-ovn-cmd f3470f4 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-openstack-ovn f3470f4 link false /test e2e-openstack-ovn
ci/prow/verify-deps f3470f4 link true /test verify-deps
ci/prow/e2e-metal-ipi-ovn-ipv6 f3470f4 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-gcp-ovn-rt-upgrade f3470f4 link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-gcp-ovn-builds f3470f4 link true /test e2e-gcp-ovn-builds
ci/prow/e2e-aws-ovn-single-node-upgrade f3470f4 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-cgroupsv2 f3470f4 link false /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-metal-ipi-sdn f3470f4 link false /test e2e-metal-ipi-sdn
ci/prow/images f3470f4 link true /test images
ci/prow/e2e-aws-ovn-fips f3470f4 link true /test e2e-aws-ovn-fips

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@benluddy
Copy link
Contributor Author

benluddy commented Jun 22, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2023
@benluddy benluddy force-pushed the sccexec-get-test-skip-proxied branch from f3470f4 to 67029f3 Compare June 22, 2023 17:50
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: benluddy
Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@benluddy
Copy link
Contributor Author

benluddy commented Jun 22, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2023
@benluddy
Copy link
Contributor Author

benluddy commented Jun 22, 2023

/payload-job periodic-ci-openshift-release-master-nightly-4.14-e2e-metal-ipi-ovn-ipv6
/payload-job periodic-ci-openshift-release-master-nightly-4.14-e2e-metal-ipi-sdn-bm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2023

@benluddy: trigger 2 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-nightly-4.14-e2e-metal-ipi-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.14-e2e-metal-ipi-sdn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/919c05b0-113e-11ee-83ab-186cdea64039-0

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 21, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 21, 2023
@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 21, 2023

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 21, 2023
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 21, 2023

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Nov 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2023

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@sosiouxme sosiouxme Awaiting requested review from sosiouxme

Assignees

No one assigned

Labels

lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@benluddy @openshift-bot