Skip to content

Revert "Add coverage for GET verb and websocket handshake to SCC exec tests."#27943

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
DennisPeriquet:revert-27836-sccexec-get-test
May 25, 2023
Merged

Revert "Add coverage for GET verb and websocket handshake to SCC exec tests."#27943
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
DennisPeriquet:revert-27836-sccexec-get-test

Conversation

@DennisPeriquet
Copy link
Contributor

@DennisPeriquet DennisPeriquet commented May 25, 2023

Reverts #27836

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This change is breaking ci 4.14 payloads

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of (job/X or job/X, test/Y tuple) to confirm the fix has corrected the problem:

/payload-job metal-ipi-ovn-ipv6
/payload-job metal-ipi-sdn-bm

This link may be helpful in understanding why the test failed kubernetes/kubernetes#103595 (comment)

cc: @benluddy

@openshift-ci openshift-ci bot requested review from mfojtik and trozet May 25, 2023 13:31
@stbenjam
Copy link
Member

/skip
/lgtm
/approve

@DennisPeriquet
Copy link
Contributor Author

/override ci/prow/e2e-agnostic-ovn-cmd
/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-aws-ovn-cgroupsv2
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-single-node

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2023

@DennisPeriquet: Overrode contexts on behalf of DennisPeriquet: ci/prow/e2e-agnostic-ovn-cmd, ci/prow/e2e-aws-csi, ci/prow/e2e-aws-ovn-cgroupsv2, ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-serial, ci/prow/e2e-aws-ovn-single-node

Details

In response to this:

/override ci/prow/e2e-agnostic-ovn-cmd
/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-aws-ovn-cgroupsv2
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DennisPeriquet, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2023
@stbenjam
Copy link
Member

stbenjam commented May 25, 2023

Note that openshift-tests accesses Metal IPv6 clusters via an HTTP proxy, and golang's websocket library doesn't support proxies, so you'll probably just need to skip this test entirely if there's any http proxy env vars set.

@stbenjam
Copy link
Member

/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-builds
/override ci/prow/e2e-gcp-ovn-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2023

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-builds, ci/prow/e2e-gcp-ovn-upgrade

Details

In response to this:

/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-builds
/override ci/prow/e2e-gcp-ovn-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit bf65296 into openshift:master May 25, 2023
@benluddy
Copy link
Contributor

Note that openshift-tests accesses Metal IPv6 clusters via an HTTP proxy, and golang's websocket library doesn't support proxies, so you'll probably just need to skip this test entirely if there's any http proxy env vars set.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants