test/extended/util/openshift/clusterversionoperator/adminack: Accept MultipleReasons #27110
Conversation
…MultipleReasons
When there's another reason like TechPreviewNoUpgrade, the CVO will be
complaining about both and set MultipleReasons. We want the test
suite to understand that that's still an AdminAckRequired complaint,
and not fail like [1]:
: [sig-cluster-lifecycle] TestAdminAck should succeed [Suite:openshift/conformance/parallel]
Run #0: 3m3s
{ fail [github.com/openshift/origin/test/extended/util/openshift/clusterversionoperator/adminack.go:117]: May 6 07:24:05.028: Error while waiting for Upgradeable to go AdminAckRequired with message "Kubernetes 1.25 and therefore OpenShift 4.12 remove several APIs which require admin consideration. Please see\nthe knowledge article https://access.redhat.com/articles/6955381 for details and instructions.\n": timed out waiting for the condition
Upgradeable: Status=False, Reason=MultipleReasons, Message="Cluster should not be upgraded between minor versions for multiple reasons: AdminAckRequired,FeatureGates_RestrictedFeatureGates_TechPreviewNoUpgrade\n* Kubernetes 1.25 and therefore OpenShift 4.12 remove several APIs which require admin consideration. Please see\nthe knowledge article https://access.redhat.com/articles/6955381 for details and instructions.\n\n* Cluster operator kube-apiserver should not be upgraded between minor versions: FeatureGatesUpgradeable: \"TechPreviewNoUpgrade\" does not allow updates".}
The Contains logic that I'm removing is from the original test-case
implementation in 4f5be5a (test: Add admin ack Upgradeable
condition gate test, 2021-10-13, openshift#26525), and seems to have been
assuming that we would concatenate the constituent reasons, instead of
replacing all of them with MultipleReasons.
[1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-ci-4.11-e2e-azure-techpreview/1522457624627384320
openshift-ci
bot
added
the
approved
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, LalatenduMohanty, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
5 participants
When there's another reason like
TechPreviewNoUpgrade, the CVO will be complaining about both and setMultipleReasons. We want the test suite to understand that that's still anAdminAckRequiredcomplaint, and not fail like:The
Containslogic that I'm removing is from the original test-case implementation in 4f5be5a (#26525), and seems to have been assuming that we would concatenate the constituent reasons, instead of replacing all of them withMultipleReasons.