Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented May 6, 2022

Reverts #772

It's tripping up tech-preview informers like this:

: [sig-cluster-lifecycle] TestAdminAck should succeed [Suite:openshift/conformance/parallel]
Run #0: Failed	3m3s

{  fail [github.com/openshift/origin/test/extended/util/openshift/clusterversionoperator/adminack.go:117]: May  6 07:24:05.028: Error while waiting for Upgradeable to go AdminAckRequired with message "Kubernetes 1.25 and therefore OpenShift 4.12 remove several APIs which require admin consideration. Please see\nthe knowledge article https://access.redhat.com/articles/6955381 for details and instructions.\n": timed out waiting for the condition
Upgradeable: Status=False, Reason=MultipleReasons, Message="Cluster should not be upgraded between minor versions for multiple reasons: AdminAckRequired,FeatureGates_RestrictedFeatureGates_TechPreviewNoUpgrade\n* Kubernetes 1.25 and therefore OpenShift 4.12 remove several APIs which require admin consideration. Please see\nthe knowledge article https://access.redhat.com/articles/6955381 for details and instructions.\n\n* Cluster operator kube-apiserver should not be upgraded between minor versions: FeatureGatesUpgradeable: \"TechPreviewNoUpgrade\" does not allow updates".}

Opening a revert while we sort out the test issue. CC @LalatenduMohanty

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2022
@LalatenduMohanty
Copy link
Member

/hold as I am trying to understand how soon we can fix origin tests

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2022
@wking
Copy link
Member Author

wking commented May 6, 2022

openshift/origin#27110 is my attempt at an origin fix, but to keep CI healthy, folks prefer reverting quickly, because real fixes can sometimes take a while, and rereverting is cheap ;).

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 6, 2022

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking
Copy link
Member Author

wking commented May 8, 2022

openshift/origin#27110 recovered the job.

@wking wking closed this May 8, 2022
@wking wking deleted the revert-772-OTA-665 branch May 8, 2022 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants