Skip to content

bug 2060406: test: bump apirequests upper bounds for VSphere and AWS single node#26962

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
ingvagabund:bump-api-requests-bounds
Apr 5, 2022
Merged

bug 2060406: test: bump apirequests upper bounds for VSphere and AWS single node#26962
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
ingvagabund:bump-api-requests-bounds

Conversation

@ingvagabund
Copy link
Member

@ingvagabund ingvagabund commented Apr 1, 2022

periodic-ci-openshift-release-master-nightly-4.11-openshift-e2e-aws-single-node-workers-upgrade-conformance sequence:

69 68 63 61 62 64 78 60 69 53 66 52 73 64 66 57 61 59 64 68 65 67 52 58 60 68 57 64 57 57 71 65 86

Giving 64 as the median

periodic-ci-openshift-release-master-nightly-4.11-e2e-vsphere-techpreview-serial sequence:

101 111 94 86 101 90 109 77 115 138 105 91 102 104 93 86 90 78 65 92 88 110 110 84 100 113 89 100 99 95 99 87 107 86 89 71 108 90 124 95 62 93 96 90 94 90 87 88 80 96 85 88 105 109 107 88 85 91 130 98 102 81 93 94

There are some spikes but mostly holding around 93/94 based on the median.

@ingvagabund ingvagabund changed the title test: bump apirequests upper bounds for VSphere and AWS single node bug 2060406: test: bump apirequests upper bounds for VSphere and AWS single node Apr 1, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 1, 2022

@ingvagabund: This pull request references Bugzilla bug 2060406, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @juzhao

Details

In response to this:

bug 2060406: test: bump apirequests upper bounds for VSphere and AWS single node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from juzhao April 1, 2022 11:58
soltysh
soltysh approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold
I've proposed bumping these limits slightly a bit more, 69 and 99, to cover a bit more, I'm fully aware that's a bit more than median.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2022
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 1, 2022
@ingvagabund
Copy link
Member Author

ingvagabund commented Apr 1, 2022

The bounds my code computes are more theoretical. Versus what is reported by the CI. Sometimes it is the median, sometimes only half of it

/hold cancel
/retest-required

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2022
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 1, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2022
@ingvagabund ingvagabund force-pushed the bump-api-requests-bounds branch from 3034ad3 to 6707bbf Compare April 3, 2022 12:22
@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 3, 2022
@ingvagabund
Copy link
Member Author

ingvagabund commented Apr 3, 2022

/retest-required

2 similar comments
@ingvagabund
Copy link
Member Author

ingvagabund commented Apr 3, 2022

/retest-required

@ingvagabund
Copy link
Member Author

ingvagabund commented Apr 4, 2022

/retest-required

@droslean
Copy link
Member

droslean commented Apr 4, 2022

/retest

@soltysh
Copy link
Contributor

soltysh commented Apr 4, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ingvagabund
Copy link
Member Author

ingvagabund commented Apr 4, 2022

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 4, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 4, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 4, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 4, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 4, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 4, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 4, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 4, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 5, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 5, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 5, 2022

@ingvagabund: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-rt-upgrade 6707bbf link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-single-node 6707bbf link false /test e2e-aws-single-node
ci/prow/e2e-aws-csi 6707bbf link false /test e2e-aws-csi
ci/prow/e2e-agnostic-cmd 6707bbf link false /test e2e-agnostic-cmd

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 9446eae into openshift:master Apr 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 5, 2022

@ingvagabund: All pull requests linked via external trackers have merged:

Bugzilla bug 2060406 has been moved to the MODIFIED state.

Details

In response to this:

bug 2060406: test: bump apirequests upper bounds for VSphere and AWS single node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund ingvagabund deleted the bump-api-requests-bounds branch April 5, 2022 07:23
@openshift-ci openshift-ci bot mentioned this pull request Apr 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@juzhao juzhao Awaiting requested review from juzhao

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ingvagabund @openshift-bot @droslean @soltysh @openshift-merge-robot

Comments