Bug 2049117: Reenable wait on worker deletion and increase serial test timeout #26810
Conversation
|
/test e2e-metal-ipi-serial |
bfournie
changed the title
bfournie
changed the title
openshift-ci
bot
added
the
bugzilla/severity-medium
|
@bfournie: This pull request references Bugzilla bug 2049117, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (augol@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
/test e2e-metal-ipi-serial |
|
The patch looks good to me, I'd just wait for #26813 to land and have another run of |
|
/test e2e-gcp-upgrade |
|
/lgtm |
|
/assign @soltysh |
|
/cc pweil- |
cmd/openshift-tests/e2e.go
Outdated
| } | ||
| return strings.Contains(name, "[Suite:openshift/conformance/serial") || isStandardEarlyOrLateTest(name) | ||
| }, | ||
| TestTimeout: 20 * time.Minute, |
There was a problem hiding this comment.
I'm fine bringing back the extra wait, but I don't want to increase the overall test timeout for everyone. Spoke with @bfournie he'll try to make it more targetted at bare metal.
bfournie
force-pushed
the
increase-serial-timeout
branch
from
8244c6f to
7322703
Compare
bfournie
force-pushed
the
increase-serial-timeout
branch
from
7322703 to
41f00ef
Compare
openshift-ci
bot
added
the
approved
|
/test e2e-metal-ipi-serial |
bfournie
force-pushed
the
increase-serial-timeout
branch
from
41f00ef to
40458cf
Compare
|
Latest update depends on #26833 as it uses the |
openshift-ci
bot
removed
the
approved
openshift-ci
bot
added
do-not-merge/hold
|
/unhold as #26833 has merged |
|
/retest-required |
|
/retest-required |
test/extended/baremetal/hosts.go
Outdated
| }) | ||
|
|
||
| g.It("skip inspection when disabled by annotation", func() { | ||
| g.It("skip inspection when disabled by annotation [Timeout:20m]", func() { |
There was a problem hiding this comment.
@bfournie looks like a typo, it's the scale&grow that needs to be increased
There was a problem hiding this comment.
@bfournie looks like a typo, it's the scale&grow that needs to be increased
Yeah that's what the test results look like. Updated timeout in scale and grow.
With the fix to remove the extra worker deletion (openshift#26774) there have been occasional test failures when the time to delete the extra worker has exceeded the 15 minute test time. This adds back in the wait after the extra worker is deleted and increases the test time to allow the deletion to complete.
bfournie
force-pushed
the
increase-serial-timeout
branch
from
40458cf to
bdaf1db
Compare
|
/test e2e-metal-ipi-serial-ovn-ipv6 |
|
@bfournie: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/test e2e-metal-ipi-serial-ovn-ipv6 |
|
@bfournie: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano, ardaguclu, bfournie, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@bfournie: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@bfournie: All pull requests linked via external trackers have merged: Bugzilla bug 2049117 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
With the fix to remove the extra worker deletion (#26774) there have been occasional test failures when the time to delete the extra worker has exceeded the 15 minute test time. This adds back in the wait after the extra worker is deleted and increases the test time to allow the deletion to complete.