Skip to content

Conversation

@andfasano
Copy link
Contributor

@andfasano andfasano commented Jan 21, 2022

Do not wait for workers to be cleaned up on teardown. Setup in any case will take care of waiting previously deleted ones (impacts only serial jobs)

@andfasano
Copy link
Contributor Author

/test e2e-metal-ipi-serial

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2022
@openshift-ci openshift-ci bot requested review from deads2k and gabemontero January 21, 2022 19:04
@bfournie
Copy link
Contributor

/lgtm
Just waiting for test results, also will need a BZ.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

20 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@ardaguclu
Copy link
Member

Since this PR has already been waiting valid-bug label, I'll run retest one more time for serial job;

/test e2e-metal-ipi-serial

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@andfasano andfasano changed the title baremetal: remove wait condition when deleting extraworkers Bug 2044210: [baremetal] remove wait condition when deleting extraworkers Jan 24, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 24, 2022

@andfasano: This pull request references Bugzilla bug 2044210, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2044210: [baremetal] remove wait condition when deleting extraworkers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andfasano
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 24, 2022

@andfasano: This pull request references Bugzilla bug 2044210, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 24, 2022

@andfasano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-cgroupsv2 c2e648e link false /test e2e-aws-cgroupsv2
ci/prow/e2e-gcp-csi c2e648e link false /test e2e-gcp-csi
ci/prow/e2e-aws-csi c2e648e link false /test e2e-aws-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 86ab9a8 into openshift:master Jan 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 24, 2022

@andfasano: All pull requests linked via external trackers have merged:

Bugzilla bug 2044210 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2044210: [baremetal] remove wait condition when deleting extraworkers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bfournie added a commit to bfournie/origin that referenced this pull request Feb 2, 2022
With the fix to remove the extra worker deletion (openshift#26774)
there have been occasional test failures when the time to delete the extra worker
has exceeded the 15 minute test time. This adds back in the wait after the extra worker
is deleted and increases the test time to allow the deletion to complete.
bfournie added a commit to bfournie/origin that referenced this pull request Feb 9, 2022
With the fix to remove the extra worker deletion (openshift#26774)
there have been occasional test failures when the time to delete the extra worker
has exceeded the 15 minute test time. This adds back in the wait after the extra worker
is deleted and increases the test time to allow the deletion to complete.
bfournie added a commit to bfournie/origin that referenced this pull request Feb 9, 2022
With the fix to remove the extra worker deletion (openshift#26774)
there have been occasional test failures when the time to delete the extra worker
has exceeded the 15 minute test time. This adds back in the wait after the extra worker
is deleted and increases the test time to allow the deletion to complete.
bfournie added a commit to bfournie/origin that referenced this pull request Feb 10, 2022
With the fix to remove the extra worker deletion (openshift#26774)
there have been occasional test failures when the time to delete the extra worker
has exceeded the 15 minute test time. This adds back in the wait after the extra worker
is deleted and increases the test time to allow the deletion to complete.
bfournie added a commit to bfournie/origin that referenced this pull request Feb 14, 2022
With the fix to remove the extra worker deletion (openshift#26774)
there have been occasional test failures when the time to delete the extra worker
has exceeded the 15 minute test time. This adds back in the wait after the extra worker
is deleted and increases the test time to allow the deletion to complete.
bfournie added a commit to bfournie/origin that referenced this pull request Feb 16, 2022
…t timeout

With the fix to remove the extra worker deletion (openshift#26774)
there have been occasional test failures when the time to delete the extra worker
has exceeded the 15 minute test time. This adds back in the wait after the extra worker
is deleted and increases the test time to allow the deletion to complete.

(cherry picked from commit bdaf1db)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants