Skip to content

Comments

Bug 1976376: builds: comment out multi-namespace template test#26275

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.8from
gabemontero:fix-rogue-client-plugin-test-48
Jun 30, 2021
Merged

Bug 1976376: builds: comment out multi-namespace template test#26275
openshift-merge-robot merged 1 commit intoopenshift:release-4.8from
gabemontero:fix-rogue-client-plugin-test-48

Conversation

@gabemontero
Copy link
Contributor

@gabemontero gabemontero commented Jun 25, 2021

a pick of just @yselkowitz 's 7e93e51 to unwedge jenkins e2e's in 4.8

I will be porting this test to the jenkins client plugin e2e's

/assign @yselkowitz

@akram @waveywaves @jkhelil @adambkaplan FYI

@yselkowitz @gabemontero
builds: comment out multi-namespace template test
45a418e 
This test relies on pulling yaml from github rather than from bindata,
which makes it difficult to pre-commit testing of changes which affect
it.  @akram and @gabemontero will move this to the jenkins client plugin
E2E, but in the meantime, we comment it out.

openshift#26072 (comment)
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jun 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

@gabemontero: This pull request references Bugzilla bug 1976376, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1976376: builds: comment out multi-namespace template test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 25, 2021
@gabemontero
Copy link
Contributor Author

gabemontero commented Jun 25, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

@gabemontero: This pull request references Bugzilla bug 1976376, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1976373 is in the state VERIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1976373 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

Requesting review from QA contact:
/cc @jitendar-singh

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 25, 2021
@openshift-ci openshift-ci bot requested a review from jitendar-singh June 25, 2021 21:34
@gabemontero
Copy link
Contributor Author

gabemontero commented Jun 25, 2021

/test e2e-aws-jenkins

@openshift-ci openshift-ci bot requested review from adambkaplan and coreydaley June 25, 2021 21:35
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2021
This was referenced Jun 25, 2021
Closed
Merged
@gabemontero
Copy link
Contributor Author

gabemontero commented Jun 25, 2021

@bparees - are you still the person to apply "group-lead-approved" labels for build/jenkins extended test PRs?

There is a chain of cause and effect in the PRs referenced in the description that has lead to some of the jenkins e2e's perm failing across releases

Addressed in master/4.9, this is the first of the back ports.

@bparees bparees added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Jun 25, 2021
@bparees
Copy link
Contributor

bparees commented Jun 25, 2021

@bparees - are you still the person to apply "group-lead-approved" labels for build/jenkins extended test PRs?

i dunno, but i'm still a person who can, anyway :)

done.

@gabemontero
Copy link
Contributor Author

gabemontero commented Jun 25, 2021 via email

@gabemontero
Copy link
Contributor Author

gabemontero commented Jun 26, 2021

the e2e-aws-jenkins test is green, which is all we touched

/retest

for the unrelated fails

@gabemontero
Copy link
Contributor Author

gabemontero commented Jun 28, 2021

/retest

adambkaplan
adambkaplan approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 29, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 29, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 29, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 29, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 29, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 29, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 29, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 29, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@akram
Copy link
Contributor

akram commented Jun 29, 2021

The test e2e-metal-ipi-ovn-dualstack seems to always fail.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2021
@gabemontero
Copy link
Contributor Author

gabemontero commented Jun 29, 2021

The test e2e-metal-ipi-ovn-dualstack seems to always fail.

/hold

#26251 is suppose to be skipping those tests in 4.8. They are already skipped in 4.9/master.

We can unhold once that merges. It is on the merge queue but is hitting, including failures with e2e-aws-jenkins which this should address. Will comment there.

@gabemontero gabemontero mentioned this pull request Jun 29, 2021
Merged
@gabemontero
Copy link
Contributor Author

gabemontero commented Jun 30, 2021

/test e2e-aws-proxy

@adambkaplan 's fix for builds has merged

@gabemontero
Copy link
Contributor Author

gabemontero commented Jun 30, 2021

So the one failure in e2e-gcp is https://bugzilla.redhat.com/show_bug.cgi?id=1975938 per https://sippy.ci.openshift.org/?release=4.8

the metal-ipi-ovn-dualstack failures were reported on sippy for 4.8 but had not BZ ... I opened https://bugzilla.redhat.com/show_bug.cgi?id=1977885 via the link on sippy

and e2e-aws-jenkins is passing which is what this PR updates

the e2e-aws-proxy run is still in flight but should pass with @adambkaplan change from yesterday

@bparees or @smarterclayton - in order to unwind 4.8 e2e's, are either of you willing to override e2e-gcp and e2e-metal-ipi-ovn-dualstack so we can get this change into 4.8 and unblock e2e-aws-jenkins?

thanks

@gabemontero
Copy link
Contributor Author

gabemontero commented Jun 30, 2021

ah well ... other stuff in e2e-aws-proxy failed here in 4.8

that said, overriding gcp and metal-ipi @bparees @smarterclayton would still progress things along if you are amenable

I'll research e2e-aws-proxy failures on 4.8 afterward

@bparees bparees mentioned this pull request Jun 30, 2021
Merged
@bparees
Copy link
Contributor

bparees commented Jun 30, 2021

/override ci/prow/e2e-gcp
/override ci/prow/e2e-metal-ipi-ovn-dualstack

will override proxy when @gabemontero refs a bug to get it back to green/confirms the failure is unrelated. Note that @knobunc had also run into the proxy job failure and said he would investigate, i dunno if he found anything so you might check w/ him.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2021

@bparees: Overrode contexts on behalf of bparees: ci/prow/e2e-gcp, ci/prow/e2e-metal-ipi-ovn-dualstack

Details

In response to this:

/override ci/prow/e2e-gcp
/override ci/prow/e2e-metal-ipi-ovn-dualstack

will override proxy when @gabemontero refs a bug to get it back to green/confirms the failure is unrelated. Note that @knobunc had also run into the proxy job failure and said he would investigate, i dunno if he found anything so you might check w/ him.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bparees
Copy link
Contributor

bparees commented Jun 30, 2021

/override ci/prow/e2e-aws-proxy

confirmed the proxy job has a config issue that needs to be tackled.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2021

@bparees: Overrode contexts on behalf of bparees: ci/prow/e2e-aws-proxy

Details

In response to this:

/override ci/prow/e2e-aws-proxy

confirmed the proxy job has a config issue that needs to be tackled.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero
Copy link
Contributor Author

gabemontero commented Jun 30, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2021
@gabemontero
Copy link
Contributor Author

gabemontero commented Jun 30, 2021

/override ci/prow/e2e-aws-proxy

confirmed the proxy job has a config issue that needs to be tackled.

thanks for following up @bparees

@openshift-merge-robot openshift-merge-robot merged commit 25ff760 into openshift:release-4.8 Jun 30, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2021

@gabemontero: All pull requests linked via external trackers have merged:

Bugzilla bug 1976376 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1976376: builds: comment out multi-namespace template test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero
Copy link
Contributor Author

gabemontero commented Jun 30, 2021

/cherrypick release-4.7

@gabemontero gabemontero deleted the fix-rogue-client-plugin-test-48 branch June 30, 2021 21:48
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 30, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 30, 2021

@gabemontero: new pull request created: #26296

Details

In response to this:

/cherrypick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero gabemontero mentioned this pull request Jul 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@jitendar-singh jitendar-singh Awaiting requested review from jitendar-singh

@coreydaley coreydaley Awaiting requested review from coreydaley

Assignees

@adambkaplan adambkaplan

@yselkowitz yselkowitz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@gabemontero @bparees @openshift-bot @akram @openshift-cherrypick-robot @adambkaplan @yselkowitz @openshift-merge-robot