Skip to content

Comments

Bug 1973667: undisable NetworkPolicy tests [4.8]#26263

Merged
openshift-merge-robot merged 3 commits intoopenshift:release-4.8from
danwinship:fix-netpol-dns-4.8
Jun 25, 2021
Merged

Bug 1973667: undisable NetworkPolicy tests [4.8]#26263
openshift-merge-robot merged 3 commits intoopenshift:release-4.8from
danwinship:fix-netpol-dns-4.8

Conversation

@danwinship
Copy link
Contributor

backport of #26231
/assign @knobunc

@openshift-ci openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Jun 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2021

@danwinship: This pull request references Bugzilla bug 1973667, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1953127 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1953127 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

Details

In response to this:

Bug 1973667: undisable NetworkPolicy tests [4.8]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 23, 2021
@openshift-ci openshift-ci bot requested a review from zhaozhanqi June 23, 2021 14:34
@knobunc knobunc added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Jun 23, 2021
@knobunc
Copy link
Contributor

knobunc commented Jun 23, 2021

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 23, 2021
@danwinship
Copy link
Contributor Author

/test e2e-metal-ipi
/test e2e-metal-ipi-ovn-ipv6
(failed due to packet.net issues before)

@knobunc
Copy link
Contributor

knobunc commented Jun 23, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

15 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

The new "Netpol" suite attempts to retry if a test fails the first
time because it started probing before the plugin fully implemented
the policy. But the retry code is broken and the tests will still fail
if they failed the first time, even if they succeed the second time.
@danwinship danwinship force-pushed the fix-netpol-dns-4.8 branch from 45ea18a to b3bfb26 Compare June 25, 2021 12:07
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2021
@knobunc
Copy link
Contributor

knobunc commented Jun 25, 2021

/override ci/prow/e2e-gcp

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

@knobunc: Overrode contexts on behalf of knobunc: ci/prow/e2e-gcp

Details

In response to this:

/override ci/prow/e2e-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knobunc
Copy link
Contributor

knobunc commented Jun 25, 2021

/override ci/prow/e2e-metal-ipi-ovn-dualstack
/override ci/prow/e2e-aws-proxy

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

@knobunc: Overrode contexts on behalf of knobunc: ci/prow/e2e-aws-proxy, ci/prow/e2e-metal-ipi-ovn-dualstack

Details

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-dualstack
/override ci/prow/e2e-aws-proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knobunc
Copy link
Contributor

knobunc commented Jun 25, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knobunc
Copy link
Contributor

knobunc commented Jun 25, 2021

/test e2e-metal-ipi-virtualmedia

@knobunc
Copy link
Contributor

knobunc commented Jun 25, 2021

/override ci/prow/e2e-aws-proxy
/override ci/prow/e2e-metal-ipi-ovn-dualstack

(Permafailing on unrelated tests, will investigate that separately)

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

@knobunc: Overrode contexts on behalf of knobunc: ci/prow/e2e-aws-proxy, ci/prow/e2e-metal-ipi-ovn-dualstack

Details

In response to this:

/override ci/prow/e2e-aws-proxy
/override ci/prow/e2e-metal-ipi-ovn-dualstack

(Permafailing on unrelated tests, will investigate that separately)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@knobunc
Copy link
Contributor

knobunc commented Jun 25, 2021

/override ci/prow/e2e-aws-upgrade
/override ci/prow/e2e-metal-ipi-virtualmedia

This has had a clean test run for both of these and is just flaking at this point on unrelated tests.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

@knobunc: Overrode contexts on behalf of knobunc: ci/prow/e2e-aws-upgrade, ci/prow/e2e-metal-ipi-virtualmedia

Details

In response to this:

/override ci/prow/e2e-aws-upgrade
/override ci/prow/e2e-metal-ipi-virtualmedia

This has had a clean test run for both of these and is just flaking at this point on unrelated tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knobunc
Copy link
Contributor

knobunc commented Jun 25, 2021

/override ci/prow/e2e-gcp-builds

This is not required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

@knobunc: Overrode contexts on behalf of knobunc: ci/prow/e2e-gcp-builds

Details

In response to this:

/override ci/prow/e2e-gcp-builds

This is not required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knobunc
Copy link
Contributor

knobunc commented Jun 25, 2021

/override ci/prow/e2e-aws-upgrade

This has passed, but is intermittently flaking on unrelated stuff. Will chase later.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

@knobunc: Overrode contexts on behalf of knobunc: ci/prow/e2e-aws-upgrade

Details

In response to this:

/override ci/prow/e2e-aws-upgrade

This has passed, but is intermittently flaking on unrelated stuff. Will chase later.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 183c4e3 into openshift:release-4.8 Jun 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

@danwinship: All pull requests linked via external trackers have merged:

Bugzilla bug 1973667 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1973667: undisable NetworkPolicy tests [4.8]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship danwinship deleted the fix-netpol-dns-4.8 branch June 25, 2021 16:36
@bparees
Copy link
Contributor

bparees commented Jun 30, 2021

/override ci/prow/e2e-aws-proxy
/override ci/prow/e2e-metal-ipi-ovn-dualstack
(Permafailing on unrelated tests, will investigate that separately)****

@knobunc did you get a chance to look into this? @gabemontero is now hitting failures in the same jobs in #26275

we need to get bugs open so we can get the required jobs on the origin repo back to green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants