Skip to content

replace registry.redhat.io refs with internal image registry refs in image-eco #25985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Mar 20, 2021
Merged

replace registry.redhat.io refs with internal image registry refs in image-eco #25985

openshift-merge-robot merged 2 commits into from
Mar 20, 2021

Conversation

@gabemontero
Copy link
Contributor

@gabemontero gabemontero commented Mar 18, 2021

See openshift/builder#228 (comment)

image-eco currently broken

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 18, 2021
@gabemontero gabemontero force-pushed the image-eco-e2e-mirror-nono branch from 5d9c4ad to a399311 Compare March 19, 2021 00:25
@gabemontero
Copy link
Contributor Author

gabemontero commented Mar 19, 2021

will most likely minimally need #25986 to bypass e2e-gcp-upgrade for merging

@gabemontero
Copy link
Contributor Author

gabemontero commented Mar 19, 2021

ok the actual image eco tests pass, the failure in it was some unrelated prometheus thing

[sig-instrumentation] Prometheus when installed on the cluster shouldn't report any alerts in firing state apart from Watchdog and AlertmanagerReceiversNotConfigured

/retest

@gabemontero
Copy link
Contributor Author

gabemontero commented Mar 19, 2021

ok the previous prometheus error is a flake vs. permfail

image-eco now green

unclear on metal-ipi-ovn-ipv6

/retest

@gabemontero
Copy link
Contributor Author

gabemontero commented Mar 19, 2021

all green e2e's

/assign @adambkaplan

adambkaplan
adambkaplan approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2021
This was referenced Mar 19, 2021
Merged
Merged
@gabemontero
Copy link
Contributor Author

gabemontero commented Mar 19, 2021

/test e2e-aws-fips

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6c84517 into openshift:master Mar 20, 2021
@gabemontero gabemontero deleted the image-eco-e2e-mirror-nono branch March 20, 2021 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@coreydaley coreydaley Awaiting requested review from coreydaley

Assignees

@adambkaplan adambkaplan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gabemontero @openshift-ci-robot @openshift-bot @adambkaplan @openshift-merge-robot