Skip to content

Bug 1896558: bump(openshift/kubernetes): fix flaking multi-AZ test#25848

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
damemi:bump-ok-multiaz-skip
Feb 8, 2021
Merged

Bug 1896558: bump(openshift/kubernetes): fix flaking multi-AZ test#25848
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
damemi:bump-ok-multiaz-skip

Conversation

@damemi
Copy link
Contributor

@damemi damemi commented Feb 2, 2021

Pulling the change from openshift/kubernetes#545, we need to debug why this test is failing

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Feb 2, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 2, 2021

@damemi: This pull request references Bugzilla bug 1896558, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1896558: bump(openshift/kubernetes): revert Multi-AZ test skip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 2, 2021
@openshift-ci-robot openshift-ci-robot added the vendor-update Touching vendor dir or related files label Feb 2, 2021
damemi
damemi commented Feb 2, 2021
View reviewed changes
Copy link
Contributor Author

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @marun @deads2k
We could hold this PR too while we work on a fix, then just include the fix here

@damemi
Copy link
Contributor Author

damemi commented Feb 3, 2021

/retest

@damemi damemi mentioned this pull request Feb 3, 2021
Merged
@damemi
Copy link
Contributor Author

damemi commented Feb 3, 2021

/hold
testing this

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2021
@damemi
Copy link
Contributor Author

damemi commented Feb 3, 2021

#25852 pulls in the unskip for this test
will keep this PR for the bump to bring in the fix from openshift/kubernetes#547

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2021
@damemi damemi force-pushed the bump-ok-multiaz-skip branch from 039f800 to 778432b Compare February 8, 2021 15:18
@damemi damemi changed the title Bug 1896558: bump(openshift/kubernetes): revert Multi-AZ test skip Bug 1896558: bump(openshift/kubernetes): fix flaking multi-AZ test Feb 8, 2021
@damemi damemi force-pushed the bump-ok-multiaz-skip branch from 778432b to 1d8c9e0 Compare February 8, 2021 15:20
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2021
@damemi
Copy link
Contributor Author

damemi commented Feb 8, 2021

/hold cancel
Will also open a bump to 4.7 to pull in openshift/kubernetes#554

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2021
soltysh
soltysh approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 8, 2021
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2021
@damemi
Copy link
Contributor Author

damemi commented Feb 8, 2021

@soltysh verify errors were legit, just re-pushed make update... can you re-tag please?

@soltysh
Copy link
Contributor

soltysh commented Feb 8, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 79f296a into openshift:master Feb 8, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 8, 2021

@damemi: All pull requests linked via external trackers have merged:

Bugzilla bug 1896558 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1896558: bump(openshift/kubernetes): fix flaking multi-AZ test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@damemi damemi deleted the bump-ok-multiaz-skip branch February 8, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjenning sjenning Awaiting requested review from sjenning

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@deads2k deads2k Awaiting requested review from deads2k

@marun marun Awaiting requested review from marun

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@damemi @openshift-ci-robot @soltysh @openshift-bot @openshift-merge-robot

Comments