Skip to content

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Aug 17, 2020

This gives distinct junit for each main failure block. Once this merges (or once this is tagged), we can update sippy to ignore the "something failed" to reduce noise.

I recommend reviewing without whitespace diff: https://github.com/openshift/origin/pull/25417/files?w=1

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2020
@mfojtik
Copy link
Contributor

mfojtik commented Aug 18, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor Author

deads2k commented Aug 18, 2020

/override ci/prow/e2e-aws-fips

updated test only this doesn't impact fips

@openshift-ci-robot
Copy link

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-aws-fips

Details

In response to this:

/override ci/prow/e2e-aws-fips

updated test only this doesn't impact fips

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link
Contributor Author

deads2k commented Aug 18, 2020

only #25386 merged since the last set of green tests. Merging to help signal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants