Bug 1826094: Add retry options to Prometheus helper curl command #25386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

openshift-merge-robot merged 1 commit into openshift:master from sgreene570:prom-test-curl-retry

Aug 18, 2020

Contributor

sgreene570 commented Aug 6, 2020

Adds --retry 15 --max-time 2 --retry-delay 1 to the Prometheus query curl call in test/extended/util/prometheus/helpers.go. This is to prevent the test from failing during the e2e-aws-scaleup-rhel7 job, where DNS pods scheduled on newly spun-up rhel7 worker nodes may not immediately be responsive. As seen in the linked BZ, the first test in test/extended/prometheus/prometheus.go is hitting DNS errors during the e2e-aws-scaleup-rhel7 job while the remainder of the prometheus tests are not, despite using the same curl code. Hence why adding the retry options will be beneficial in reducing test failures.

/assign @Miciah
/cc @danehans @frobware


          test/extended/prometheus: Add retry options to RunQueries() curl command

e358cc5

openshift-ci-robot assigned Miciah

openshift-ci-robot requested review from danehans and frobware

August 6, 2020 19:59

openshift-ci-robot added bugzilla/severity-medium bugzilla/valid-bug labels

openshift-ci-robot commented Aug 6, 2020

@sgreene570: This pull request references Bugzilla bug 1826094, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1826094: Add retry options to Prometheus helper curl command

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor

Miciah commented Aug 6, 2020

/lgtm
/assign @knobunc
to /approve.

openshift-ci-robot assigned knobunc

openshift-ci-robot added the lgtm label

Contributor Author

sgreene570 commented Aug 7, 2020

/test e2e-aws-fips

2 similar comments

Contributor Author

sgreene570 commented Aug 7, 2020

/test e2e-aws-fips

Contributor Author

sgreene570 commented Aug 10, 2020

/test e2e-aws-fips

Contributor

knobunc commented Aug 10, 2020

/approve

openshift-ci-robot commented Aug 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, Miciah, sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/extended/OWNERS~~ [knobunc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the approved label

Contributor

openshift-bot commented Aug 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

13 similar comments

Contributor

openshift-bot commented Aug 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 15, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

26 similar comments

Contributor

openshift-bot commented Aug 15, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 15, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 15, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 15, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 15, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-merge-robot merged commit 77ca7ed into openshift:master

openshift-ci-robot commented Aug 18, 2020

@sgreene570: All pull requests linked via external trackers have merged: openshift/origin#25386. Bugzilla bug 1826094 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1826094: Add retry options to Prometheus helper curl command

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

deads2k mentioned this pull request

finish splitting each part of the upgrade into distinct junit #25417

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved bugzilla/severity-medium bugzilla/valid-bug lgtm