-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Bug 1826183: Verify builds use custom CA bundle #25156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@adambkaplan: This pull request references Bugzilla bug 1826183, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
openshift/builder#158 and openshift/openshift-controller-manager#119 should merge in order for the test to pass. If it passes now, we have a problem. |
|
/lgtm once openshift/builder#158 and openshift/openshift-controller-manager#119 merge. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, danehans The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add an e2e test to verify that builds use a custom CA bundle if one is added to the cluster proxy config.
6a3bcb0 to
20e18b6
Compare
|
/retest |
|
@adambkaplan: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/close This test is inherently flaky because changing the PKI causes node drain events. Even running the test serially, the build pod gets deleted more than 50% of the time. This may be best verified manually by QE. |
|
@adambkaplan: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add an e2e test to verify that builds use a custom CA bundle if one is added to the cluster
proxy config.