Skip to content

Conversation

@adambkaplan
Copy link
Contributor

Add an e2e test to verify that builds use a custom CA bundle if one is added to the cluster
proxy config.

@openshift-ci-robot
Copy link

@adambkaplan: This pull request references Bugzilla bug 1826183, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1826183: Verify builds use custom CA bundle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 18, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2020
@adambkaplan
Copy link
Contributor Author

openshift/builder#158 and openshift/openshift-controller-manager#119 should merge in order for the test to pass. If it passes now, we have a problem.

@danehans
Copy link
Contributor

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, danehans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Add an e2e test to verify that builds use a custom CA bundle if one is added to the cluster
proxy config.
@adambkaplan
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link

@adambkaplan: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-cmd 20e18b6 link /test e2e-cmd
ci/prow/e2e-gcp-builds 20e18b6 link /test e2e-gcp-builds

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@adambkaplan
Copy link
Contributor Author

/close

This test is inherently flaky because changing the PKI causes node drain events. Even running the test serially, the build pod gets deleted more than 50% of the time. This may be best verified manually by QE.

@openshift-ci-robot
Copy link

@adambkaplan: Closed this PR.

Details

In response to this:

/close

This test is inherently flaky because changing the PKI causes node drain events. Even running the test serially, the build pod gets deleted more than 50% of the time. This may be best verified manually by QE.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants