Skip to content

Bug 1826183: Configure Build Pods to Merge CAs #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Aug 2, 2020
Merged

Bug 1826183: Configure Build Pods to Merge CAs #119

openshift-merge-robot merged 1 commit into from
Aug 2, 2020

Conversation

@adambkaplan
Copy link
Contributor

@adambkaplan adambkaplan commented Jun 18, 2020

  • Mount the cluster PKI trust bundle in a neutral location. openshift/builder is
    responsible for copying this file to /etc/pki/ca-trust/source/anchors, then running
    update-ca-trust extract. This will generate trust bundles for all types of processes
    (email, TLS, JVMs, etc.).
  • Use Args instead of Command when running builder image. This ensures the
    entrypoint script for openshift/builder is always invoked.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 18, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 18, 2020

@adambkaplan: This pull request references Bugzilla bug 1826183, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1826183: Configure Build Pods to Merge CAs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2020
@gabemontero
Copy link
Contributor

gabemontero commented Jun 18, 2020

are any openshift/builder changes coming to complete the end to end flow here @adambkaplan , or is what the builder is doing and/or whatever provided assemble scripts are doing sufficient ?

@adambkaplan
Copy link
Contributor Author

adambkaplan commented Jun 18, 2020

@gabemontero openshift/builder changes coming - this PR should fail the build suite without that change in.

@adambkaplan
Copy link
Contributor Author

adambkaplan commented Jun 18, 2020

builder PR that needs to merge first: openshift/builder#158

@adambkaplan adambkaplan mentioned this pull request Jun 18, 2020
Closed
@adambkaplan
Copy link
Contributor Author

adambkaplan commented Jun 22, 2020

/hold

Need feedback from the Network team if this is the right thing to do.

/cc @danehans

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2020
@adambkaplan adambkaplan mentioned this pull request Jun 22, 2020
Merged
@adambkaplan
Copy link
Contributor Author

adambkaplan commented Jul 6, 2020

Per discussion with @danehans [1], we will also need to fix the operator so that it copies the user-ca trust bundle. Today we rely on the network operator injecting the global trust bundle, which is not applicable to our situation.

[1] openshift/builder#158 (comment)

@adambkaplan
Bug 1826183: Configure Build Pods to Merge CAs
ad84e02 
* Mount the cluster PKI trust bundle in a neutral location. openshift/builder is
  responsible for copying this file to /etc/pki/ca-trust/source/anchors, then running
  `update-ca-trust extract`. This will generate trust bundles for all types of processes
  (email, TLS, JVMs, etc.).
* Use `Args` instead of `Command` when running builder image. This ensures the
  entrypoint script for openshift/builder is always invoked.
* Copy the user-ca bundle to build pods, instead of the global-ca. This ConfigMap will
  only exist if the cluster is configured with a trustedCA for the proxy.
@adambkaplan adambkaplan force-pushed the propagate-ca-buildah branch from b9be835 to ad84e02 Compare July 15, 2020 18:46
@adambkaplan
Copy link
Contributor Author

adambkaplan commented Jul 15, 2020

/hold

Maintaining the hold because this PR needs openshift/cluster-openshift-controller-manager-operator#162 to merge first.

@adambkaplan adambkaplan mentioned this pull request Jul 16, 2020
Merged
@adambkaplan
Copy link
Contributor Author

adambkaplan commented Jul 23, 2020

/test e2e-aws

@adambkaplan
Copy link
Contributor Author

adambkaplan commented Jul 23, 2020

/test e2e-aws-builds

@adambkaplan
Copy link
Contributor Author

adambkaplan commented Jul 23, 2020

/hold cancel

/assign @coreydaley

e2e tests need to be re-run now that the operator PR has merged.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2020
@adambkaplan
Copy link
Contributor Author

adambkaplan commented Jul 23, 2020

/test e2e-aws-upgrade

@coreydaley
Copy link

coreydaley commented Jul 31, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 31, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, coreydaley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit fe7a3a2 into openshift:master Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@gabemontero gabemontero Awaiting requested review from gabemontero

@danehans danehans Awaiting requested review from danehans

Assignees

@coreydaley coreydaley

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@adambkaplan @openshift-ci-robot @gabemontero @coreydaley @openshift-bot @openshift-merge-robot