Skip to content

Revert "Bug 1683057: Fix router metrics test flakes" #24083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
smarterclayton wants to merge 1 commit into from
Closed

Revert "Bug 1683057: Fix router metrics test flakes" #24083

smarterclayton wants to merge 1 commit into from

Conversation

@smarterclayton
Copy link
Contributor

@smarterclayton smarterclayton commented Nov 4, 2019 •
edited
Loading

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 4, 2019

@smarterclayton: This pull request references Bugzilla bug 1683057, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Revert "Bug 1683057: Fix router metrics test flakes"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 4, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2019
@smarterclayton
Copy link
Contributor Author

smarterclayton commented Nov 4, 2019

/test e2e-aws

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Nov 4, 2019

/retest

This was referenced Nov 4, 2019
Merged
Closed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 4, 2019

@smarterclayton: This pull request references Bugzilla bug 1683057, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Revert "Bug 1683057: Fix router metrics test flakes"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ironcladlou
Copy link
Contributor

ironcladlou commented Nov 4, 2019

I think #24085 fixes the AWS flake introduced by #24075

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Nov 4, 2019

Superseded by correct fix: #24085

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

@knobunc knobunc Awaiting requested review from knobunc

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smarterclayton @openshift-ci-robot @ironcladlou