setup-etcd-environment: support scaling from cluster-etcd-operator

[hexfusion]

The discovery init container is a very important part of the bootstraping process. Currently, we use SRV queries to populate ENV variables consumed by other containers in the pod.

As we move to an operator managed etcd cluster additional data points and validations need to be performed. The scaling of etcd is managed by the clustermembercontroller (CMC). When a new candidate for membership is verified as Ready to join the cluster the CMC populates a ConfigMap with basic information for the scaling process. This information includes details on the current members of the cluster. From this information, we can then populate the ETCD_INITIAL_CLUSTER variable which directs etcd on who its peers are.

To manage new candidates from racing only 1 member can scale at a time. Until that member has been added and verified no other member can be added. We do this by doing a wait until we observe the data identifying the pod as scaling.

We also populate a new ENV variable ETCD_ENDPOINTS this is used later on in the process by a new init container called membership.

Pending changes: The following items will change in the near future.

• the member-config ConfigMap will stop using annotations for scaling data instead a more traditional data: key.

depends on #1224

[alaypatel07]

depends on #1224, needs rebase after that gets in, thanks

[hexfusion]

cmd/setup-etcd-environment/run.go:56:1: cyclomatic complexity 34 of func runRunCmd is high (> 30) (gocyclo)
func runRunCmd(cmd *cobra.Command, args []string) error {

Is this a new test I don't think we changed this.

https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/1221/pull-ci-openshift-machine-config-operator-master-verify/2211#1:build-log.txt%3A18

Update: We have a fix

[hexfusion]

fail [k8s.io/kubernetes/test/e2e/apimachinery/resource_quota.go:167]: Unexpected error:
    <*errors.errorString | 0xc00029c0c0>: {
        s: "timed out waiting for the condition",
    }
    timed out waiting for the condition
occurred

[hexfusion]

/test e2e-aws

[hexfusion]

/test e2e-aws

[hexfusion]

trying to understand this failure.

/test e2e-aws

[hexfusion]

test failures related to regression in aws tests openshift/origin#24083

[retroflexer]

/lgtm

[hexfusion]

/retest

[kikisdeliveryservice]

looks good

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, kikisdeliveryservice, retroflexer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hexfusion]

/skip

[hexfusion]

/test e2e-aws

[hexfusion]

/retest

[hexfusion]

/retest

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[hexfusion]

e2e-gcp-op still needs manual override it has the same failure.

cc @kikisdeliveryservice @runcom

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@hexfusion: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-scaleup-rhel7	37e6851	link	/test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[hexfusion]

/retest