Bug 1698543: bump libcontainer/runc and deps #23860

rphillips · 2019-09-25T15:46:59Z

Bump opencontainer/runc fork pin to pull in this commit to fix delegation not available errors.

Note This patch also pins openshift/{api,client-go,library-go,apiserver-library-go} to release branches.

The diff is large based on running make update-deps which is standard.

ref: https://bugzilla.redhat.com/show_bug.cgi?id=1698543

/cc @mrunalp @sjenning

openshift-ci-robot · 2019-09-25T15:47:02Z

@rphillips: This pull request references Bugzilla bug 1698543, which is invalid:

expected the bug to target the "4.2.z" release, but it targets "4.2.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1698543: bump libcontainer/runc and deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2019-09-25T15:47:25Z

@rphillips: This pull request references Bugzilla bug 1698543, which is invalid:

expected the bug to target the "4.2.z" release, but it targets "4.2.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1698543: bump libcontainer/runc and deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rphillips · 2019-09-25T15:48:10Z

/bugzilla refresh

openshift-ci-robot · 2019-09-25T15:48:16Z

@rphillips: This pull request references Bugzilla bug 1698543, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rphillips · 2019-09-25T15:54:29Z

Compile error.

vendor/github.com/openshift/api/authorization/v1/generated.pb.go:59:28: undefined: proto.InternalMessageInfo

rphillips · 2019-09-25T18:38:01Z

/hold

working on a different fix with @mrunalp

…8dbcd1424

openshift-ci-robot · 2019-09-25T19:23:17Z

@rphillips: This pull request references Bugzilla bug 1698543, which is invalid:

expected the bug to target the "4.2.z" release, but it targets "4.2.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1698543: bump libcontainer/runc and deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rphillips · 2019-09-25T19:24:11Z

/hold cancel

mrunalp · 2019-09-25T20:33:23Z

/retest

openshift-ci-robot · 2019-09-25T21:02:18Z

@rphillips: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-dr-quorum-tests	`2ef1716`	link	`/test e2e-dr-quorum-tests`
ci/prow/e2e-dr-snapshot-tests	`2ef1716`	link	`/test e2e-dr-snapshot-tests`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rphillips · 2019-09-25T21:16:39Z

/bugzilla refresh

openshift-ci-robot · 2019-09-25T21:16:42Z

@rphillips: This pull request references Bugzilla bug 1698543, which is valid.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mrunalp · 2019-09-25T21:25:36Z

/lgtm

mrunalp · 2019-09-25T22:37:04Z

@smarterclayton ptal

rphillips · 2019-09-25T22:56:19Z

bot got updated to target 4.2.0...

/bugzilla refresh

openshift-ci-robot · 2019-09-25T22:56:22Z

@rphillips: This pull request references Bugzilla bug 1698543, which is valid.

Details

In response to this:

bot got updated to target 4.2.0...

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2019-09-25T23:00:08Z

/bugzilla refresh

openshift-ci-robot · 2019-09-25T23:00:11Z

@openshift-bot: This pull request references Bugzilla bug 1698543, which is valid.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2019-09-25T23:11:33Z

glide.yaml

 # openshift second
 - package: github.com/openshift/api
-  version: master
+  version: release-4.2


This feels like something that should happen automatically when we fork an origin branch off master. Is there a plan to make that happen, or is it up to whoever makes the first post-fork vendor bump to do this?

Yeah, I think this was missed upon branching.

wking · 2019-09-25T23:24:02Z

Also, the Bugzilla bot is currently accepting rhbz#1698543 because there is no blocking 4.3.0 bug; otherwise it would need a VERIFIED 4.3.0 bug. Z patch managers could override that by setting labels manually, but we definitely don't want to fix this in 4.2 and then forget to fix it in 4.3.0. Maybe 88baf7f (#23811) obsoletes this bump in the master branch, but I think our current policy is to have blocking 4.3.0 bugs so QE can verify that we aren't leaking the fix.

rphillips · 2019-09-26T16:54:53Z

@wking Got the 4.3 BZ and PR available.

blomquisg · 2019-09-27T18:23:00Z

/bugzilla refresh

openshift-ci-robot · 2019-09-27T18:23:03Z

@blomquisg: This pull request references Bugzilla bug 1698543, which is invalid:

expected dependent Bugzilla bug 1755991 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

blomquisg · 2019-09-27T18:23:54Z

Had to reverse the BZ dependencies (4.3.0 should block 4.2.0). This PR will be blocked until the 4.3.0 BZ is verified

nee1esh · 2019-10-01T14:33:24Z

/bugzilla refresh

openshift-ci-robot · 2019-10-01T14:33:27Z

@nee1esh: This pull request references Bugzilla bug 1698543, which is invalid:

expected dependent Bugzilla bug 1755991 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nee1esh · 2019-10-01T14:36:32Z

@eparis Can we get this approved for BZ process exception and cherry-picked for 4.2? 4.3 PR is merged. According to Seth "we don't have a recreate procedure for it and don't really know how it happens. we just removed the code that makes it possible."

eparis · 2019-10-01T19:56:55Z

/approve

openshift-ci-robot · 2019-10-01T19:57:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, mrunalp, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [eparis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2019-10-01T20:33:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-10-01T20:46:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-10-01T20:59:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-10-01T21:13:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-10-01T22:56:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2019-10-01T23:20:45Z

@rphillips: All pull requests linked via external trackers have merged. Bugzilla bug 1698543 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1698543: bump libcontainer/runc and deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from mrunalp and sjenning September 25, 2019 15:47

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 25, 2019

openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 25, 2019

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 25, 2019

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2019

rphillips added 2 commits September 25, 2019 14:15

bump(*)

c6f25ff

bump(github.com/opencontainers/runc): a7f8722a9c79bf82b30f93f7f86a376…

048c028

…8dbcd1424

rphillips force-pushed the bump/libcontainer_4.2 branch from 797c846 to 048c028 Compare September 25, 2019 19:16

bump(github.com/openshift/apiserver-library-go): pin to release branch

2ef1716

openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 25, 2019

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2019

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 25, 2019

openshift-ci-robot assigned mrunalp Sep 25, 2019

wking reviewed Sep 25, 2019

View reviewed changes

rphillips mentioned this pull request Sep 26, 2019

Bug 1755991: bump runc for delegation fix #23868

Merged

openshift-ci-robot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 27, 2019

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 27, 2019

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2019

openshift-merge-robot merged commit b6f8dda into openshift:release-4.2 Oct 1, 2019

Bug 1698543: bump libcontainer/runc and deps #23860

Bug 1698543: bump libcontainer/runc and deps #23860

Uh oh!

Conversation

rphillips commented Sep 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 25, 2019

Uh oh!

openshift-ci-robot commented Sep 25, 2019

Uh oh!

rphillips commented Sep 25, 2019

Uh oh!

openshift-ci-robot commented Sep 25, 2019

Uh oh!

rphillips commented Sep 25, 2019

Uh oh!

rphillips commented Sep 25, 2019

Uh oh!

openshift-ci-robot commented Sep 25, 2019

Uh oh!

rphillips commented Sep 25, 2019

Uh oh!

mrunalp commented Sep 25, 2019

Uh oh!

openshift-ci-robot commented Sep 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rphillips commented Sep 25, 2019

Uh oh!

openshift-ci-robot commented Sep 25, 2019

Uh oh!

mrunalp commented Sep 25, 2019

Uh oh!

mrunalp commented Sep 25, 2019

Uh oh!

rphillips commented Sep 25, 2019

Uh oh!

openshift-ci-robot commented Sep 25, 2019

Uh oh!

openshift-bot commented Sep 25, 2019

Uh oh!

openshift-ci-robot commented Sep 25, 2019

Uh oh!

wking Sep 25, 2019

Choose a reason for hiding this comment

Uh oh!

rphillips Sep 26, 2019

Choose a reason for hiding this comment

Uh oh!

wking commented Sep 25, 2019

Uh oh!

rphillips commented Sep 26, 2019

Uh oh!

blomquisg commented Sep 27, 2019

Uh oh!

openshift-ci-robot commented Sep 27, 2019

Uh oh!

blomquisg commented Sep 27, 2019

Uh oh!

nee1esh commented Oct 1, 2019

Uh oh!

openshift-ci-robot commented Oct 1, 2019

Uh oh!

nee1esh commented Oct 1, 2019

Uh oh!

eparis commented Oct 1, 2019

Uh oh!

openshift-ci-robot commented Oct 1, 2019

Uh oh!

openshift-bot commented Oct 1, 2019

Uh oh!

openshift-bot commented Oct 1, 2019

Uh oh!

openshift-bot commented Oct 1, 2019

Uh oh!

openshift-bot commented Oct 1, 2019

Uh oh!

openshift-bot commented Oct 1, 2019

Uh oh!

rphillips commented Sep 25, 2019 •

edited

Loading

openshift-ci-robot commented Sep 25, 2019 •

edited

Loading