Skip to content

Bump to kubernetes 1.16.0 rc.2 #23811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mfojtik merged 66 commits into from
Sep 23, 2019
Merged

Bump to kubernetes 1.16.0 rc.2 #23811

mfojtik merged 66 commits into from
Sep 23, 2019

Conversation

@p0lyn0mial
Copy link
Contributor

@p0lyn0mial p0lyn0mial commented Sep 17, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 17, 2019
@p0lyn0mial p0lyn0mial force-pushed the origin-4.3-kubernetes-1.16.0-rc.2 branch from ac7f131 to 6ffdf15 Compare September 19, 2019 12:41
@p0lyn0mial
Copy link
Contributor Author

p0lyn0mial commented Sep 19, 2019

/retest

@p0lyn0mial
Copy link
Contributor Author

p0lyn0mial commented Sep 20, 2019

/test e2e-aws-image-ecosystem

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2019
@p0lyn0mial p0lyn0mial force-pushed the origin-4.3-kubernetes-1.16.0-rc.2 branch from 2a0ae41 to d455448 Compare September 20, 2019 19:33
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2019
@p0lyn0mial p0lyn0mial force-pushed the origin-4.3-kubernetes-1.16.0-rc.2 branch from d455448 to 6d27a43 Compare September 20, 2019 22:19
@p0lyn0mial
Copy link
Contributor Author

p0lyn0mial commented Sep 21, 2019

/test e2e-aws-builds

2 similar comments
@p0lyn0mial
Copy link
Contributor Author

p0lyn0mial commented Sep 21, 2019

/test e2e-aws-builds

@p0lyn0mial
Copy link
Contributor Author

p0lyn0mial commented Sep 21, 2019

/test e2e-aws-builds

@deads2k
Copy link
Contributor

deads2k commented Sep 21, 2019

we will need a bug for the CRD issue. I think we more the generation to openshift/api on Monday.

@deads2k
Copy link
Contributor

deads2k commented Sep 21, 2019

@sttts the openapi bits are going to make you cranky, but landing this before we open up is more important than describe.

@deads2k
Copy link
Contributor

deads2k commented Sep 21, 2019

Based on the last push time, we're short several patches. On Monday, please be sure to push them.

1f24b29 is the last one I know of so far.

@p0lyn0mial
Copy link
Contributor Author

p0lyn0mial commented Sep 21, 2019

Based on the last push time, we're short several patches. On Monday, please be sure to push them.

Sure, np, I'm going to add those directly into this pull since adding into the fork might not work because of the automation (publishing bots).

@p0lyn0mial
Copy link
Contributor Author

p0lyn0mial commented Sep 22, 2019

/test e2e-aws

@p0lyn0mial p0lyn0mial force-pushed the origin-4.3-kubernetes-1.16.0-rc.2 branch 2 times, most recently from d70c00c to d2555ed Compare September 23, 2019 09:34
mfojtik
mfojtik reviewed Sep 23, 2019
View reviewed changes
mfojtik
mfojtik reviewed Sep 23, 2019
View reviewed changes
mfojtik
mfojtik reviewed Sep 23, 2019
View reviewed changes
sttts and others added 11 commits September 23, 2019 12:04
@sttts @p0lyn0mial
CHECK(cesarwong): extended: make HPA RC test serial, but disabled
eb4c42a 
Test runs fine when launched separately, but not in the CI test, neither in serial nor in the normal suite.
@sttts @p0lyn0mial
CHECK(sdn): e2e: disable failing NetworkPolicy ingress test
2410e3d
@sttts @p0lyn0mial
Update version string
8c10d33
@p0lyn0mial
UPSTREAM: 82189: add conditions for remaining object totals during ns…
3059714 
… termination
@p0lyn0mial
CHECK(sttts): disables oc explain tests as our CRD are non-structural
befc020
@sttts @p0lyn0mial
UPSTREAM: 82759: validations: for negative PVC storage size don't rep…
b7b7391 
…ort "must be >= 0"
@gnufied @p0lyn0mial
UPSTREAM: 82760: Enable upgrade tests on all cloudproviders
bec2bd2
@deads2k @p0lyn0mial
UPSTREAM: <carry>: make the namespace controller recheck once a minute
efea6de
@deads2k @p0lyn0mial
UPSTREAM: 82803: dump namespace object in e2e when it doesn't get del…
c61c462 
…eted
@damemi @p0lyn0mial
UPSTREAM: <carry>: Change timeout in eviction e2e test to account for…
8b16aa1 
… new kubelet delay in pod deletion
@jsafrane @p0lyn0mial
UPSTREAM: 82830: Do not query the cloud if PV has all the labels
bc28bd9 
Fixed not to require pkg/controller/volume/persistentvolume/util, which is
avalable only in 1.16
@p0lyn0mial p0lyn0mial force-pushed the origin-4.3-kubernetes-1.16.0-rc.2 branch from d2555ed to bc28bd9 Compare September 23, 2019 10:06
@mfojtik
Copy link
Contributor

mfojtik commented Sep 23, 2019

/retest

AWS flake

@mfojtik mfojtik mentioned this pull request Sep 23, 2019
Closed
@mfojtik
Copy link
Contributor

mfojtik commented Sep 23, 2019

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2019
@mfojtik mfojtik changed the title [WIP] Bump to kubernetes 1.16.0 rc.2 Bump to kubernetes 1.16.0 rc.2 Sep 23, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2019
@mfojtik
Copy link
Contributor

mfojtik commented Sep 23, 2019 •
edited
Loading

the image-ecosystem seems to be failing on:

Cloning "https://github.com/sclorg/cakephp-ex.git" ...
error: fatal: unable to access 'https://github.com/sclorg/cakephp-ex.git/': Could not resolve host: github.com; Unknown error

@mfojtik
Copy link
Contributor

mfojtik commented Sep 23, 2019

/retest

@deads2k
Copy link
Contributor

deads2k commented Sep 23, 2019

Images has worked in the past. I will merge when we're ready.

@mfojtik mfojtik merged commit 6ae0a50 into openshift:master Sep 23, 2019
deads2k added a commit to deads2k/origin that referenced this pull request Sep 23, 2019
@deads2k
Revert "Merge pull request openshift#23811 from p0lyn0mial/origin-4.3…
887b931 
…-kubernetes-1.16.0-rc.2"

This reverts commit 6ae0a50, reversing
changes made to 4965b8c.
@wking wking mentioned this pull request Sep 25, 2019
Merged
@wking wking mentioned this pull request Oct 20, 2019
Merged
@damemi damemi mentioned this pull request Nov 7, 2019
Closed
@danwinship danwinship mentioned this pull request Oct 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@coreydaley coreydaley Awaiting requested review from coreydaley

1 more reviewer

@mfojtik mfojtik mfojtik left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mfojtik mfojtik

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@p0lyn0mial @deads2k @mfojtik @openshift-ci-robot @sttts @jsafrane @gnufied @damemi