Install CSI driver on openshift-test start.

[jsafrane]

Goal: create a prow job that tests CSI sidecars shipped as part of OCP / OKD. In the future, use the same approach to test CSI drivers too.

There are 6 CSI sidecars in total (and the number is growing), so to simplify job definition in each repostory, I embedded AWS EBS driver yaml files into openshift-tests.

Prow configs for each sidecar repo would then contain something like this:

- as: e2e-aws-csi
  commands: TEST_INSTALL_CSI_DRIVERS=aws-ebs TEST_SUITE=openshift/csi run-tests
  openshift_installer:
    cluster_profile: aws
    upgrade: false

Env. variables are the easiest to pass between parent openshift-test and child openshift-test processes. It's a bit hacky though. I tried command line arguments, you can find the unsuccessful attempt in the commits in this PR.

The architecture is open for multiple CSI drivers, we will ship drivers for all clouds that we support eventually. In addition, we can easily replace yaml files with CSI drivers with CRs for an operator that installs CSI drivers, when we have them.

Future direction:

• Add such prow job to all CSI sidecar repos + origin (to catch openshift-test changes & rebases).
• When we add operators for CSI drivers (4.4?), use OLM manifests / CRDs for driver installation instead current yaml files.

/assign @smarterclayton

[smarterclayton]

Who calls this?

[jsafrane]

It's called from initProvider:

origin/cmd/openshift-tests/openshift-tests.go

Lines 277 to 286 in d88cc07

	func initProvider(provider string, dryRun bool) error {
	// record the exit error to the output file
	if err := decodeProviderTo(provider, exutil.TestContext); err != nil {
	return err
	}
	exutil.TestContext.AllowedNotReadyNodes = 100
	exutil.TestContext.MaxNodesToGather = 0
	reale2e.SetViperConfig(os.Getenv("VIPERCONFIG"))
	if err := initCSITests(); err != nil {

[smarterclayton]

/hold cancel
/lgtm

[jsafrane]

/retest

[tsmetana]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, smarterclayton, tsmetana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• cmd/OWNERS [smarterclayton]
• test/extended/OWNERS [smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[jsafrane]

/retest

[openshift-ci-robot]

@jsafrane: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-upgrade	b309828	link	/test e2e-aws-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jsafrane]

/retest