Add CSI Cloning enhancement.

[huffmanca]

Includes the enhancement file for including CSI Cloning. This is largely based on the upstream KEP.

[huffmanca]

@tsmetana , @gnufied , @jsafrane ,

Looking for review and feedback on this enhancement request.

[jsafrane]

I personally think that OpenShift enhancements should not cover upstream work. We should link upstream KEPs and documentation, but copying them here is IMO not useful.

We should cover work we're going to do to enable cloning in OpenShift, so:

• We as engineering know what to do (we need rebase of this and that, we need this e2e test).
• QA knows what is in scope of the feature and what is out of scope, so they can test it.
• Documentation team can find upstream docs.

The comments below are trying to move the enhancement in this direction and are valid only if the direction itself is correct :-).

[jsafrane]

We should write stories for us, i.e. "as OCS developer, I want to release my CSI driver with cloning support so ...".

[huffmanca]

I've removed the previous stories and created a single one for us.

At present, due to the limited audience and availability, I've only included the single story.

[jsafrane]

You should mention we want e2e tests with Red Hat's CSI sidecars, maybe link openshift/origin#23560 and https://jira.coreos.com/browse/STOR-223

Link to usptream e2e tests could be useful so we know what we want to run and QA (or someone) can check that we actually completed the goal.

[huffmanca]

I've updated this section to include both of the links above. It also includes a link to where I believe CSI cloning is tested, and the README on defining additional CSI Drivers for testing.

[huffmanca]

@jsafrane ,

Thank you for the in-depth review. I've updated the PR to better reflect the usage for OCP, and less the upstream proposal. This PR should now be ready for rereview.

[jsafrane]

I have only couple of minor comments

[jsafrane]

lgtm
@openshift/storage anyone else want to take a look?

[bertinatto]

LGTM too, only a minor question.

[bertinatto]

/lgtm

[bertinatto]

/assign @knobunc
for approval

[knobunc]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, huffmanca, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [knobunc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment