Skip to content

Switch to go1.11 #22666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 27, 2019
Merged

Switch to go1.11 #22666

openshift-merge-robot merged 1 commit into from
Apr 27, 2019

Conversation

@soltysh
Copy link
Contributor

@soltysh soltysh commented Apr 25, 2019

Out of curiosity I'm opening a rebased version of #22510

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 25, 2019
@soltysh
Copy link
Contributor Author

soltysh commented Apr 26, 2019

This is passing unlike #22510, I'm tagging that based on the other one, since this is the same thing only rebased on newer version.

@soltysh soltysh changed the title [WIP] Switch to go1.11 Switch to go1.11 Apr 26, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 26, 2019
@soltysh soltysh added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Apr 26, 2019
@soltysh
Copy link
Contributor Author

soltysh commented Apr 26, 2019

/retest

@soltysh soltysh mentioned this pull request Apr 26, 2019
Closed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 26, 2019

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Contributor Author

soltysh commented Apr 26, 2019

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 26, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 26, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 27, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 64bb216 into openshift:master Apr 27, 2019
@soltysh soltysh deleted the go1.11_new branch May 16, 2019 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giuseppe giuseppe Awaiting requested review from giuseppe

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@soltysh @openshift-ci-robot @openshift-bot @openshift-merge-robot