Skip to content

Switch to go1.11 #22510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
soltysh wants to merge 1 commit into from
Closed

Switch to go1.11 #22510

soltysh wants to merge 1 commit into from

Conversation

@soltysh
Copy link
Contributor

@soltysh soltysh commented Apr 9, 2019 •
edited
Loading

Followup to #22523
/assign @smarterclayton

@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 9, 2019
@soltysh soltysh mentioned this pull request Apr 9, 2019
Merged
@bparees
Copy link
Contributor

bparees commented Apr 9, 2019

@soltysh seems worthy of an aos-devel announcement.

@soltysh
Copy link
Contributor Author

soltysh commented Apr 9, 2019

@bparees there will be one when we'll be close, it's a few days away still, just starting 😉

smarterclayton
smarterclayton reviewed Apr 9, 2019
View reviewed changes
origin.spec
%global import_path github.com/openshift/origin

%global golang_version 1.10
%global golang_version 1.11
Copy link
Contributor

@smarterclayton smarterclayton Apr 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check with @sosiouxme on this change

Copy link
Contributor

@smarterclayton smarterclayton Apr 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably will have to open a pr to ocp-build-data

Copy link
Contributor Author

@soltysh soltysh Apr 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do.

Copy link
Contributor Author

@soltysh soltysh Apr 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already there.

Copy link
Member

@sosiouxme sosiouxme Apr 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apparently i forgot to comment here.
the spec file requesting 1.11 should suffice to get it.
image configs in ocp-build-data should already be updated for when this lands.

@smarterclayton
Copy link
Contributor

smarterclayton commented Apr 9, 2019

/retest

1 similar comment
@smarterclayton
Copy link
Contributor

smarterclayton commented Apr 10, 2019

/retest

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 10, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 10, 2019 •
edited
Loading

@soltysh: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-builds fc359a0 link /test e2e-aws-builds

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@soltysh
Copy link
Contributor Author

soltysh commented Apr 10, 2019

/retest

@sosiouxme
Copy link
Member

sosiouxme commented Apr 10, 2019

should be fine in OCP. go-toolset-1.11 and shim are available.

@smarterclayton
Copy link
Contributor

smarterclayton commented Apr 16, 2019

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2019
@soltysh
Copy link
Contributor Author

soltysh commented Apr 16, 2019

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2019
@soltysh
Copy link
Contributor Author

soltysh commented Apr 16, 2019

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 17, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 17, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 17, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 17, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@soltysh
Copy link
Contributor Author

soltysh commented Apr 24, 2019

Hmmm... none of the failures seems related to this PR in particular. Most of them are related to unauthorized errors, none of which are coming from these changes.
/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2019
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

21 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@soltysh
Copy link
Contributor Author

soltysh commented Apr 25, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2019
@soltysh soltysh mentioned this pull request Apr 25, 2019
Merged
@soltysh
Copy link
Contributor Author

soltysh commented Apr 26, 2019

Closing in favor of #22666.

@soltysh soltysh closed this Apr 26, 2019
@soltysh soltysh deleted the go1.11 branch April 26, 2019 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sosiouxme sosiouxme sosiouxme left review comments

@bparees bparees Awaiting requested review from bparees

@csrwng csrwng Awaiting requested review from csrwng

+1 more reviewer

@smarterclayton smarterclayton smarterclayton left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@smarterclayton smarterclayton

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@soltysh @bparees @smarterclayton @openshift-ci-robot @sosiouxme @openshift-bot