Skip to content

test/extended/prometheus: temporarily disable scheduler metrics checks #22574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Apr 16, 2019
Merged

test/extended/prometheus: temporarily disable scheduler metrics checks #22574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions test/extended/prometheus/prometheus.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,12 @@ var _ = g.Describe("[Feature:Prometheus][Conformance] Prometheus", func() {
targets.Expect(labels{"job": "apiserver"}, "up", "^https://.*/metrics$"),
// TODO: add openshift api
// TODO: this should be https
// targets.Expect(labels{"job": "kube-controller-manager"}, "up", "^http://.*/metrics$"),
// TODO: check only for https after merging https://github.com/openshift/cluster-monitoring-operator/pull/308
targets.Expect(labels{"job": "scheduler"}, "up", "^(http|https)://.*/metrics$"),
// TODO: check control plane once the following PRs land:
// - https://github.com/openshift/cluster-kube-scheduler-operator/pull/97
// - https://github.com/openshift/installer/pull/1576
// - https://github.com/openshift/cluster-monitoring-operator/pull/316
// targets.Expect(labels{"job": "kube-controller-manager"}, "up", "^https://.*/metrics$"),
// targets.Expect(labels{"job": "scheduler"}, "up", "^https://.*/metrics$"),
targets.Expect(labels{"job": "kube-state-metrics"}, "up", "^https://.*/metrics$"),
// TODO: should probably be https
targets.Expect(labels{"job": "cluster-version-operator"}, "up", "^http://.*/metrics$"),
Expand Down