Skip to content

test/extended/prometheus: temporarily disable scheduler metrics checks#22574

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
s-urbaniak:e2e-control-plane
Apr 16, 2019
Merged

test/extended/prometheus: temporarily disable scheduler metrics checks#22574
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
s-urbaniak:e2e-control-plane

Conversation

@s-urbaniak
Copy link
Copy Markdown
Contributor

@s-urbaniak s-urbaniak commented Apr 15, 2019

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 15, 2019
@brancz
Copy link
Copy Markdown
Contributor

brancz commented Apr 15, 2019

For explanation: all of the PRs referenced in the comment need to be merged for this test to be green again, so we're disabling it, waiting to see the PRs go green, and then re-enabling it.

@brancz
Copy link
Copy Markdown
Contributor

brancz commented Apr 15, 2019

/lgtm

@sttts
Copy link
Copy Markdown
Contributor

sttts commented Apr 15, 2019

We need this to avoid the chicken and egg problem switching over scheduler metrics to secure ports.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2019
@brancz
Copy link
Copy Markdown
Contributor

brancz commented Apr 15, 2019

(as a follow up, the monitoring config for the scheduler and controller-manager will be moved out of the cluster-monitoring-operator to the respective second level operator, as each team/component owns its own monitoring configuration, then situation like this won't have to involve the monitoring team in the future)

@mfojtik
Copy link
Copy Markdown
Contributor

mfojtik commented Apr 15, 2019

/lgtm

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, mfojtik, s-urbaniak, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2019
@s-urbaniak
Copy link
Copy Markdown
Contributor Author

s-urbaniak commented Apr 15, 2019

/test e2e-aws-serial

@s-urbaniak
Copy link
Copy Markdown
Contributor Author

s-urbaniak commented Apr 15, 2019

/retest

5 similar comments
@s-urbaniak
Copy link
Copy Markdown
Contributor Author

s-urbaniak commented Apr 16, 2019

/retest

@paulfantom
Copy link
Copy Markdown
Contributor

paulfantom commented Apr 16, 2019

/retest

@sttts
Copy link
Copy Markdown
Contributor

sttts commented Apr 16, 2019

/retest

@paulfantom
Copy link
Copy Markdown
Contributor

paulfantom commented Apr 16, 2019

/retest

@paulfantom
Copy link
Copy Markdown
Contributor

paulfantom commented Apr 16, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 3334d3d into openshift:master Apr 16, 2019
@s-urbaniak s-urbaniak deleted the e2e-control-plane branch April 16, 2019 20:22
@s-urbaniak s-urbaniak mentioned this pull request Apr 16, 2019
Merged
@soltysh soltysh mentioned this pull request Apr 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brancz brancz Awaiting requested review from brancz

@paulfantom paulfantom Awaiting requested review from paulfantom

@sttts sttts Awaiting requested review from sttts

Assignees

@mfojtik mfojtik

@sttts sttts

@brancz brancz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@s-urbaniak @brancz @sttts @mfojtik @openshift-ci-robot @paulfantom @openshift-merge-robot