Make sure SIGTERM shutdown the controller manager and scheduler API server#22543
Merged
deads2k merged 5 commits intoopenshift:masterfrom Apr 12, 2019
Merged
Make sure SIGTERM shutdown the controller manager and scheduler API server#22543deads2k merged 5 commits intoopenshift:masterfrom
deads2k merged 5 commits intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
the
approved
mfojtik
force-pushed
the
stop-gracefully
branch
2 times, most recently
from
7eaf8ca to
add0bf5
Compare
mfojtik
changed the title
mfojtik
force-pushed
the
stop-gracefully
branch
from
add0bf5 to
c70bc12
Compare
openshift-ci-robot
added
size/S
mfojtik
force-pushed
the
stop-gracefully
branch
2 times, most recently
from
c97e9bc to
8fd48ef
Compare
Contributor
Author
|
/retest |
2 similar comments
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
mfojtik
changed the title
mfojtik
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
mfojtik
force-pushed
the
stop-gracefully
branch
from
8fd48ef to
f08fb6a
Compare
mfojtik
changed the title
deads2k
reviewed
Apr 11, 2019
Contributor
|
Wow, this is a dense pull. I've had to go back to review other blockers. That's interesting |
Contributor
Author
|
/refresh |
mfojtik
force-pushed
the
stop-gracefully
branch
from
f08fb6a to
44fa669
Compare
Contributor
Author
|
/retest |
mfojtik
removed
the
do-not-merge/work-in-progress
This was referenced Apr 12, 2019
sttts
reviewed
Apr 12, 2019
mfojtik
force-pushed
the
stop-gracefully
branch
from
44fa669 to
1aecdea
Compare
Contributor
Author
|
/retest |
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
flake fix, green merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right know the upstream does not call the
server.Shutdown()when the controller manager receives SIGTERM. The SIGTERMstopChis not even wired into controller manager and scheduler.In that case, when the controller manager or scheduler are terminated, their ports will keep open until kernel timeout is hit (~60s++) and the port is freed. Since for these two components we use host network, this is causing the operator observing container restart in pod and ultimately setting failure condition to true.