Skip to content

manifests: extended wait for port time to 105s#218

Closed
mfojtik wants to merge 1 commit intoopenshift:masterfrom
mfojtik:wait-longer-for-port
Closed

manifests: extended wait for port time to 105s#218
mfojtik wants to merge 1 commit intoopenshift:masterfrom
mfojtik:wait-longer-for-port

Conversation

@mfojtik
Copy link
Copy Markdown
Contributor

@mfojtik mfojtik commented Apr 11, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 11, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2019
@mfojtik mfojtik force-pushed the wait-longer-for-port branch from 1dcc6e1 to c387319 Compare April 11, 2019 09:23
@mfojtik mfojtik changed the title manifests: extended wait for port time to 90s manifests: extended wait for port time to 105s Apr 11, 2019
soltysh
soltysh approved these changes Apr 11, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mfojtik
Copy link
Copy Markdown
Contributor Author

mfojtik commented Apr 11, 2019

/retest

@mfojtik
Copy link
Copy Markdown
Contributor Author

mfojtik commented Apr 12, 2019

/hold

we might not need to do this if we close the ports properly openshift/origin#22543

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2019
@ravisantoshgudimetla
Copy link
Copy Markdown
Contributor

ravisantoshgudimetla commented Apr 19, 2019

/test e2e-aws

@ravisantoshgudimetla
Copy link
Copy Markdown
Contributor

ravisantoshgudimetla commented Apr 19, 2019

I am testing this PR to see if resourcequota featuregate PR is having any effect.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 30, 2019

@mfojtik: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-upgrade c387319 link /test e2e-aws-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mfojtik mfojtik closed this Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sttts sttts Awaiting requested review from sttts

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mfojtik @openshift-ci-robot @ravisantoshgudimetla @soltysh