UPSTREAM: 69890: Run static pods before bootstrap #21274
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
|
/retest |
smarterclayton
force-pushed
the
test_upstream
branch
from
b4770cf to
5b99794
Compare
openshift-ci-robot
added
size/XL
|
/retest |
Perform bootstrapping in the background when client cert rotation is on, enabling static pods to start before a control plane is reachable.
smarterclayton
force-pushed
the
test_upstream
branch
from
5b99794 to
04a9289
Compare
openshift-ci-robot
added
size/L
|
/retest |
|
/skip |
|
/test launch-gcp |
|
/test e2e-gcp-launch |
|
@aaronlevy @crawford @deads2k @sjenning this has been tested manually pretty well. since we haven't rebased to 1.12 yet, we could merge this and then update the installer - allowing us to use static pods even if bootstrapping while the master is down (I tested on a one node master cluster). the delta for a 1.12 backports is pretty small, so it's a low risk carry for us to develop against while we finish out the upstream. At worst, we just get extra testing. So I'd probably say we should merge even assuming it changes some upstream, assume that we can carry it throughout 4.0 if necessary, and then hopefully have it in 1.13. /retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Leaving this under the hold until I sync with David in the morning. Were we blocked on moving etcd to static pod on this? Or were there other things in the way of that? |
smarterclayton
changed the title
My understanding was that this was the only thing in the way. |
|
David agreed verbally, merging. |
smarterclayton
removed
the
do-not-merge/work-in-progress
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Yeah, it makes sense for us to do this. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Crio is super flaky. I’m going to spawn issues for it, but for now I’m going to merge to unblock static pods |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@smarterclayton: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 participants
Perform bootstrapping in the background when client cert rotation is on,
enabling static pods to start before a control plane is reachable.
Argument that we enable this in master now for testing and to allow the installer to start consuming it. We then backport it to 1.12 when the rebase lands.