-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Updated Project Template examples #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@smarterclayton @csrwng @VojtechVitek review pls. |
|
LGTM |
|
lgtm |
|
@mfojtik we're going to add the |
api/examples/template_example_1.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there a pod object here?
|
Cancel LGTM, a few question |
|
@smarterclayton JSON update, deployment can have multiple podTemplate defined (?) (if I understood that correctly ;-) Also added @smarterclayton since now I'm confused ;-) I'm not sure if were talked about |
|
@mfojtik imho multiple |
|
We discussed this on IRC with @csrwng that for the projectTemplate it makes sense to have multiple However, once the project template is instantiated those deploymentConfigs will execute their deployments and that will result to 1+N deployments. We will need the somewhere store the information that these 1+N deployments belongs to a 'Project'. Does that makes sense? |
|
@VojtechVitek good catch, yeah we will need to use plurals for arrays. |
|
@smarterclayton ping? is this good for merge and being picked up next sprint? or do we want to add more things as we discussed, like routing or API namespacing? |
|
@VojtechVitek i'm thinking about nuking template_2 as this template is the same as template_1 example. No point of having both and updating both. |
|
@mfojtik agreed, no need of multiple files atm. |
api/examples/template_example_1.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we have more than 1 deploymentConfig, shouldn't this be called deploymentConfigs?
|
LGTM |
|
The json file successfully validated with json schema from #25 |
Updated Project Template examples
Use @dl-horizontal-breakpoint
serviceLinksconceptServiceandpodTemplateare now sharing the same schema as Kubernetes