Skip to content

Conversation

@mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Aug 15, 2014

  • Dropping serviceLinks concept
  • Service and podTemplate are now sharing the same schema as Kubernetes

@mfojtik
Copy link
Contributor Author

mfojtik commented Aug 15, 2014

@smarterclayton @csrwng @VojtechVitek review pls.

This was referenced Aug 15, 2014
@smarterclayton
Copy link
Contributor

LGTM

@VojtechVitek
Copy link
Contributor

lgtm

@VojtechVitek
Copy link
Contributor

@mfojtik we're going to add the replica parameter examples in the subsequent PRs, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there a pod object here?

@smarterclayton
Copy link
Contributor

Cancel LGTM, a few question

@mfojtik
Copy link
Contributor Author

mfojtik commented Aug 15, 2014

@smarterclayton JSON update, deployment can have multiple podTemplate defined (?) (if I understood that correctly ;-) Also added services.

@smarterclayton since now I'm confused ;-) I'm not sure if were talked about deploymentConfig having multiple deployments defined or a deployment have multiple podtemplates defined ;-)

@VojtechVitek
Copy link
Contributor

@mfojtik imho multiple deploymentConfigs or deployments (which one?) having only one podTemplate

@mfojtik
Copy link
Contributor Author

mfojtik commented Aug 15, 2014

@smarterclayton

We discussed this on IRC with @csrwng that for the projectTemplate it makes sense to have multiple deploymentConfig defined for scenarios where you want to have frontend->database/caching/etc

However, once the project template is instantiated those deploymentConfigs will execute their deployments and that will result to 1+N deployments. We will need the somewhere store the information that these 1+N deployments belongs to a 'Project'. Does that makes sense?

@mfojtik
Copy link
Contributor Author

mfojtik commented Aug 15, 2014

@VojtechVitek good catch, yeah we will need to use plurals for arrays.

@mfojtik
Copy link
Contributor Author

mfojtik commented Aug 19, 2014

@smarterclayton ping?

is this good for merge and being picked up next sprint? or do we want to add more things as we discussed, like routing or API namespacing?

@mfojtik
Copy link
Contributor Author

mfojtik commented Aug 19, 2014

@VojtechVitek i'm thinking about nuking template_2 as this template is the same as template_1 example. No point of having both and updating both.

@VojtechVitek
Copy link
Contributor

@mfojtik agreed, no need of multiple files atm.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have more than 1 deploymentConfig, shouldn't this be called deploymentConfigs?

@VojtechVitek
Copy link
Contributor

LGTM

@VojtechVitek
Copy link
Contributor

The json file successfully validated with json schema from #25

smarterclayton added a commit that referenced this pull request Aug 19, 2014
Updated Project Template examples
@smarterclayton smarterclayton merged commit 4e9efe2 into openshift:master Aug 19, 2014
pweil- referenced this pull request in pweil-/origin Sep 30, 2014
spadgett pushed a commit to spadgett/origin that referenced this pull request Mar 23, 2016
soltysh referenced this pull request in soltysh/origin Dec 20, 2016
@mfojtik mfojtik deleted the template_example branch September 5, 2018 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants